Fix RelocInfo::Mode enum wrt LAST_STANDARD_NONCOMPACT_ENUM.

Fix RelocInfo::Mode enum wrt LAST_STANDARD_NONCOMPACT_ENUM.

R=svenpanne@chromium.org

Committed: https://crrev.com/5095a6f50118d58d01f5a2c6eb8b174ddb8251ec
Cr-Commit-Position: refs/heads/master@{#27216}

[Yang, 2015-03-16 08:02:19]

This is a follow-up to https://codereview.chromium.org/1008823002/

[Sven Panne, 2015-03-16 08:06:49]

https://codereview.chromium.org/1011613003/diff/1/src/assembler.h
File src/assembler.h (right):

https://codereview.chromium.org/1011613003/diff/1/src/assembler.h#newcode408
src/assembler.h:408: LAST_STANDARD_NONCOMPACT_ENUM = INTERNAL_REFERENCE_ENCODED
This is only used for a DCHECK, which can actually be done at compile time. Can
we simply turn this into a STATIC_ASSERT in this header? This would keep things
together which actually belong together.

[Yang, 2015-03-16 08:26:45]

On 2015/03/16 08:06:49, Sven Panne wrote:
> https://codereview.chromium.org/1011613003/diff/1/src/assembler.h
> File src/assembler.h (right):
> 
> https://codereview.chromium.org/1011613003/diff/1/src/assembler.h#newcode408
> src/assembler.h:408: LAST_STANDARD_NONCOMPACT_ENUM =
INTERNAL_REFERENCE_ENCODED
> This is only used for a DCHECK, which can actually be done at compile time.
Can
> we simply turn this into a STATIC_ASSERT in this header? This would keep
things
> together which actually belong together.

Good point. Turns out kMaxStandardNonCompactModes is simply the size of { 0, 1,
.. kPoolExtraTag }.

[Sven Panne, 2015-03-16 11:14:42]

The CQ bit was checked by svenpanne@chromium.org

[Sven Panne, 2015-03-16 11:14:42]

lgtm

[commit-bot: I haz the power, 2015-03-16 11:14:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1011613003/20001

[commit-bot: I haz the power, 2015-03-16 11:43:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-16 11:43:44]

Patchset 2 (id:??) landed as
https://crrev.com/5095a6f50118d58d01f5a2c6eb8b174ddb8251ec
Cr-Commit-Position: refs/heads/master@{#27216}