Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart

Issue 1011613002: Issue 22845. Rename should prevent the use of invalid identifiers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart b/pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart
index 04f7e03e8010c87bf1831baf3d2972514cfba81a..4652ecaf3524acdc28a70013b0c85741640aaa34 100644
--- a/pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart
@@ -479,6 +479,12 @@ class NamingConventionsTest extends RefactoringTest {
expectedMessage: "Method name must not be empty.");
}
+ void test_validateMethodName_keyword() {
+ assertRefactoringStatus(
+ validateMethodName("for"), RefactoringProblemSeverity.FATAL,
+ expectedMessage: "Method name must not be a keyword.");
+ }
+
void test_validateMethodName_leadingBlanks() {
assertRefactoringStatus(
validateMethodName(" newName"), RefactoringProblemSeverity.FATAL,
« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698