Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1955)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1011593002: Sync the HTMLM*Element interfaces with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, kenneth.christiansen, feature-media-reviews_chromium.org, philipj_slow, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, vivekg, dglazkov+blink, nessy, Inactive, vcarbune.chromium
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync the HTMLM*Element interfaces with the spec No FIXME was added for HTMLMapElement.images, as it seems unlikely that we will actually implement it. A spec bug was filed instead: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28219 There are no changes to the generated code other than order. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191890

Patch Set 1 #

Patch Set 2 : oops inconsistent URLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -32 lines) Patch
M Source/core/html/HTMLMapElement.idl View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/HTMLMarqueeElement.idl View 1 chunk +12 lines, -8 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 4 chunks +17 lines, -11 lines 0 comments Download
M Source/core/html/HTMLMenuElement.idl View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/html/HTMLMenuItemElement.idl View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMetaElement.idl View 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMeterElement.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLModElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-15 17:01:06 UTC) #2
philipj_slow
oops inconsistent URLs
5 years, 9 months ago (2015-03-15 17:03:06 UTC) #3
haraken
LGTM
5 years, 9 months ago (2015-03-15 23:32:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011593002/20001
5 years, 9 months ago (2015-03-16 02:22:12 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 02:29:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191890

Powered by Google App Engine
This is Rietveld 408576698