Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1011553003: Use v8::Context::kDebugIdIndex instead of hardwired constant in gin (Closed)

Created:
5 years, 9 months ago by yurys
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use v8::Context::kDebugIdIndex instead of hardwired constant in gin BUG=466631 Committed: https://crrev.com/ea4636ec3229685a87244d76c6ab144ee86a801c Cr-Commit-Position: refs/heads/master@{#321534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gin/public/context_holder.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
yurys
5 years, 9 months ago (2015-03-19 08:18:54 UTC) #2
jochen (gone - plz use gerrit)
On 2015/03/19 at 08:18:54, yurys wrote: > What if the constant was eg 42, would ...
5 years, 9 months ago (2015-03-19 08:30:44 UTC) #3
yurys
On 2015/03/19 08:30:44, jochen (slow) wrote: > On 2015/03/19 at 08:18:54, yurys wrote: > > ...
5 years, 9 months ago (2015-03-19 09:09:28 UTC) #4
jochen (gone - plz use gerrit)
k, probably not worthwhile lgtm like this
5 years, 9 months ago (2015-03-19 09:41:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011553003/1
5 years, 9 months ago (2015-03-20 06:44:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/47106)
5 years, 9 months ago (2015-03-20 07:13:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011553003/1
5 years, 9 months ago (2015-03-20 07:32:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 08:54:05 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 08:55:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea4636ec3229685a87244d76c6ab144ee86a801c
Cr-Commit-Position: refs/heads/master@{#321534}

Powered by Google App Engine
This is Rietveld 408576698