Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 101153003: Remove TreatNullAs=NullString for HTMLHtmlElement (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLHtmlElement http://whatwg.org/html#HTMLHtmlElement-partial The manifest attribute is not in the spec, so leave it alone pending a decision about what to do with it: https://groups.google.com/a/chromium.org/d/msg/blink-dev/dSTAYLhhV3o/2Sh66-B7oAIJ The test passes in Firefox Nightly, IE11 Release Preview and Opera 12.16. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLHtmlElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years ago (2013-12-03 10:42:38 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-03 11:20:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/101153003/1
7 years ago (2013-12-03 11:56:04 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-03 12:48:07 UTC) #4
Message was sent while issue was closed.
Change committed as 163082

Powered by Google App Engine
This is Rietveld 408576698