Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 1011523002: Confirm the compostion text on TAP gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/ime_adapter_android.cc
diff --git a/content/browser/renderer_host/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc
index ac820f5765c3a7bf214293e8271e7bba7951f972..0ede46588d5e0afdbf5a51953c8c23dc9211b195 100644
--- a/content/browser/renderer_host/ime_adapter_android.cc
+++ b/content/browser/renderer_host/ime_adapter_android.cc
@@ -227,6 +227,14 @@ void ImeAdapterAndroid::CancelComposition() {
Java_ImeAdapter_cancelComposition(AttachCurrentThread(), obj.obj());
}
+bool ImeAdapterAndroid::HasComposition() {
jdduke (slow) 2015/03/18 19:50:08 Would it be worth simply moving all the FinishComp
+ base::android::ScopedJavaLocalRef<jobject> obj =
+ java_ime_adapter_.get(AttachCurrentThread());
+ if (!obj.is_null())
+ return Java_ImeAdapter_hasComposition(AttachCurrentThread(), obj.obj());
+ return false;
+}
+
void ImeAdapterAndroid::FocusedNodeChanged(bool is_editable_node) {
base::android::ScopedJavaLocalRef<jobject> obj =
java_ime_adapter_.get(AttachCurrentThread());

Powered by Google App Engine
This is Rietveld 408576698