Confirm the compostion text on TAP gesture.

content/browser/renderer_host/render_widget_host_view_android.cc

Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 339fec9359479b8e4d1c9ffaf578260748595c82..3786b4220e1b3d19782510baad4e208d2f132c09 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -1744,6 +1744,11 @@ void RenderWidgetHostViewAndroid::RunAckCallbacks() {
 
 void RenderWidgetHostViewAndroid::OnGestureEvent(
     const ui::GestureEventData& gesture) {
+  // Confirm existing composition text on TAP gesture, to make sure the input
+  // caret won't be moved with an ongoing composition text.
+  if (gesture.type() == ui::ET_GESTURE_TAP)
+    FinishImeCompositionSession();

[jdduke (slow), 2015/03/16 15:11:31]

+aurimas.

Why is this behavior Android-specific? Also, is there anything special about a
tap here vs, say, a click? Could this be done at a lower level (e.g., if we see
a tap event in the render process, can we do the right thing there?).

[Miyoung Shin, 2015/03/17 00:40:35]

I tried to have the consistent behavior with aura port.

render_widget_host_view_aura.cc
void RenderWidgetHostViewAura::OnMouseEvent(ui::MouseEvent* event) {
...
    if (event->type() == ui::ET_MOUSE_PRESSED)
      FinishImeCompositionSession();

void RenderWidgetHostViewAura::OnGestureEvent(ui::GestureEvent* event) {
...
  if (event->type() == ui::ET_GESTURE_TAP)
    FinishImeCompositionSession();

If we do it in the render process, we would remove the above code. WDYT ?

+
   blink::WebGestureEvent web_gesture =
       CreateWebGestureEventFromGestureEventData(gesture);
   // TODO(jdduke): Remove this workaround after Android fixes UiAutomator to
@@ -1928,6 +1933,14 @@ void RenderWidgetHostViewAndroid::OnStylusSelectTap(base::TimeTicks time,
   SendGestureEvent(long_press);
 }
 
+void RenderWidgetHostViewAndroid::FinishImeCompositionSession() {
+  if (host_) {

[jdduke (slow), 2015/03/17 18:47:21]

So, the different with RWHVAura is that hey actually track
|has_composition_text_|, avoiding the IPC if they don't need it. Perhaps there's
an ImeAdapterAndroid method we can query? We might as well add this for mouse
click as well I suppose?

[Miyoung Shin, 2015/03/18 16:44:27]

I've uploaded the patch to add hasComposition method in ImeAdapterAndroid as
|has_composition_text_|.

+    host_->ImeConfirmComposition(base::string16(), gfx::Range::InvalidRange(),
+                                 false);
+  }
+  ImeCancelComposition();
+}
+
 // static
 void RenderWidgetHostViewBase::GetDefaultScreenInfo(
     blink::WebScreenInfo* results) {