Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10115018: Convert the infobars interactive_ui_test to a browser_test. Remove the ExtensionProxy class which… (Closed)

Created:
8 years, 8 months ago by jam
Modified:
8 years, 8 months ago
CC:
chromium-reviews, robertshield, kkania, mihaip+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Convert the infobars ui_test to a browser_test. Remove the ExtensionProxy class which is now unused, its associated test, and the all the dependent code. BUG=121574 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132796

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -1066 lines) Patch
D chrome/browser/automation/automation_extension_tracker.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/automation/automation_extension_tracker.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/browser/automation/automation_provider.h View 5 chunks +0 lines, -53 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 8 chunks +0 lines, -252 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 3 chunks +0 lines, -40 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 3 chunks +6 lines, -91 lines 0 comments Download
A + chrome/browser/infobars/infobars_browsertest.cc View 1 1 chunk +65 lines, -36 lines 0 comments Download
D chrome/browser/infobars/infobars_uitest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +1 line, -4 lines 0 comments Download
M chrome/common/automation_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/automation_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/automation_messages_internal.h View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +0 lines, -16 lines 0 comments Download
D chrome/test/automation/extension_proxy.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/test/automation/extension_proxy.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/test/automation/extension_proxy_uitest.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D chrome/test/data/extensions/uitest/rename_tab.crx View Binary file 0 comments Download
D chrome/test/data/extensions/uitest/simple_browser_action.crx View Binary file 0 comments Download
M chrome/test/webdriver/webdriver_automation.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/webdriver/webdriver_automation.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/test/webdriver/webdriver_session.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/webdriver/webdriver_session.cc View 1 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
8 years, 8 months ago (2012-04-18 04:41:56 UTC) #1
Avi (use Gerrit)
lgtm
8 years, 8 months ago (2012-04-18 13:04:06 UTC) #2
jam
Ken: can you please confirm that the webdriver changes are fine?
8 years, 8 months ago (2012-04-18 14:48:21 UTC) #3
kkania
8 years, 8 months ago (2012-04-18 15:28:26 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698