Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1011493003: alt SkEvalQuadAt that returns its answer, using Sk2f (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

alt SkEvalQuadAt that returns its answer, using Sk2f BUG=skia: Committed: https://skia.googlesource.com/skia/+/65cb2cd2f7ad4146f055810b8bd77bff03a4e76e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -25 lines) Patch
M bench/GeometryBench.cpp View 1 chunk +46 lines, -0 lines 1 comment Download
M src/core/SkGeometry.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/core/SkGeometry.cpp View 2 chunks +19 lines, -21 lines 0 comments Download
M tests/GeometryTest.cpp View 3 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011493003/1
5 years, 9 months ago (2015-03-19 03:17:08 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-19 03:17:09 UTC) #3
reed2
5 years, 9 months ago (2015-03-19 03:39:23 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-19 09:17:20 UTC) #7
reed1
ptal
5 years, 9 months ago (2015-03-19 16:48:22 UTC) #9
mtklein
lgtm https://codereview.chromium.org/1011493003/diff/1/bench/GeometryBench.cpp File bench/GeometryBench.cpp (right): https://codereview.chromium.org/1011493003/diff/1/bench/GeometryBench.cpp#newcode149 bench/GeometryBench.cpp:149: for (int i = 0; i < 10000; ...
5 years, 9 months ago (2015-03-19 17:06:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011493003/1
5 years, 9 months ago (2015-03-19 17:18:38 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 17:18:51 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/65cb2cd2f7ad4146f055810b8bd77bff03a4e76e

Powered by Google App Engine
This is Rietveld 408576698