Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1011433002: base: "implement" seek time detection for iOS/Android and add more stubs. (Closed)

Created:
5 years, 9 months ago by Dan Beam
Modified:
5 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, rkaplow
Base URL:
https://chromium.googlesource.com/chromium/src.git@ssd
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: "implement" seek time detection for iOS/Android and add more stubs. BUG=463209 R=rvargas@chromium.org TBR=asvitkine@chromium.org Committed: https://crrev.com/f4a0d6b3eb666ef634d719e4d5ddc0dee3bb0d12 Cr-Commit-Position: refs/heads/master@{#321224}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : update proto comment #

Patch Set 4 : #if !defined(OS_CHROMEOS) in _linux.cc #

Patch Set 5 : -OS_ANDROID #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M base/sys_info_android.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M base/sys_info_chromeos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/sys_info_freebsd.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/sys_info_ios.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M base/sys_info_linux.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M base/sys_info_mac.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/sys_info_openbsd.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/sys_info_posix.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/metrics/proto/system_profile.proto View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
Dan Beam
5 years, 9 months ago (2015-03-14 03:18:02 UTC) #2
rvargas (doing something else)
lgtm
5 years, 9 months ago (2015-03-16 20:02:01 UTC) #4
Dan Beam
+asvitkine@ for components/metrics
5 years, 9 months ago (2015-03-18 00:30:38 UTC) #6
Dan Beam
TBR=asvitkine@ as it's a comment-only change that was reviewed internally
5 years, 9 months ago (2015-03-18 18:35:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011433002/60001
5 years, 9 months ago (2015-03-18 18:36:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/19141)
5 years, 9 months ago (2015-03-18 18:49:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011433002/80001
5 years, 9 months ago (2015-03-18 19:13:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/53308)
5 years, 9 months ago (2015-03-18 19:28:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011433002/100001
5 years, 9 months ago (2015-03-18 21:22:34 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 9 months ago (2015-03-18 22:44:23 UTC) #21
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/f4a0d6b3eb666ef634d719e4d5ddc0dee3bb0d12 Cr-Commit-Position: refs/heads/master@{#321224}
5 years, 9 months ago (2015-03-18 22:45:11 UTC) #22
Alexei Svitkine (slow)
5 years, 8 months ago (2015-03-31 18:59:10 UTC) #23
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698