Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 101143006: Convert base::file_util to use File instead of PlatformFile. (Closed)

Created:
6 years, 11 months ago by rvargas (doing something else)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), tzik, alecflett, amit, dcheng, dgrogan, markusheintz_, aandrey+blink_chromium.org, kinuko+watch, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, gavinp+disk_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, cmumford, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, nhiroki, paulirish+reviews_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, jsbell, Lei Zhang, tfarina, yurys, garykac+watch_chromium.org, tommycli, lambroslambrou+watch_chromium.org, Greg Billock, alexeypa+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Convert base::file_util to use File instead of PlatformFile. BUG=322664 R=brettw@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243235

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove base:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -156 lines) Patch
M base/file_util.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M base/file_util.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M base/file_util_posix.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/file_util_unittest.cc View 2 chunks +1 line, -20 lines 0 comments Download
M base/file_util_win.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M base/files/file_path_watcher_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M base/files/file_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M base/files/file_util_proxy.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/files/file_util_proxy_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M base/files/important_file_writer.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M base/nix/mime_util_xdg.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_file_system_indexer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iapps_finder_impl_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/duplicate_tree_detector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/install_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/common/config_dir_policy_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/dragged_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/local_file_util_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/file_utilities_message_filter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/plugin_list_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_data_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_file_element_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_file_element_reader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_test_util.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M net/disk_cache/simple/simple_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_version_upgrade.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_file_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_file_job.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/pairing_registry_delegate_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/policy_hack/policy_watcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/zlib/google/zip.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/local_file_stream_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/browser/fileapi/native_file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webfileutilities_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rvargas (doing something else)
Please take a look.
6 years, 11 months ago (2014-01-04 06:16:14 UTC) #1
brettw
lgtm https://codereview.chromium.org/101143006/diff/100001/base/file_util.h File base/file_util.h (right): https://codereview.chromium.org/101143006/diff/100001/base/file_util.h#newcode303 base/file_util.h:303: BASE_EXPORT FILE* OpenFile(const base::FilePath& filename, const char* mode); ...
6 years, 11 months ago (2014-01-04 21:49:39 UTC) #2
rvargas (doing something else)
Thanks!. +darin owners TBR. https://codereview.chromium.org/101143006/diff/100001/base/file_util.h File base/file_util.h (right): https://codereview.chromium.org/101143006/diff/100001/base/file_util.h#newcode303 base/file_util.h:303: BASE_EXPORT FILE* OpenFile(const base::FilePath& filename, ...
6 years, 11 months ago (2014-01-06 19:30:05 UTC) #3
darin (slow to review)
LGTM
6 years, 11 months ago (2014-01-06 21:31:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/101143006/180001
6 years, 11 months ago (2014-01-06 21:54:33 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 10:07:08 UTC) #6
Message was sent while issue was closed.
Change committed as 243235

Powered by Google App Engine
This is Rietveld 408576698