Issue 1011403005: Revert of Ensure that we use different glyph entries for regular and df text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1011403005: Revert of Ensure that we use different glyph entries for regular and df text. (Closed)

Created:
5 years, 9 months ago by jvanverth1

Modified:
5 years, 9 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Ensure that we use different glyph entries for regular and df text. (patchset #2 id:20001 of https://codereview.chromium.org/1020593003/) Reason for revert: Bad glyphs in dftext GM. Original issue's description: > Ensure that we use different glyph entries for regular and df text. > > Currently if we switch between regular text and df text while using > the same GrContext, they may use the same entry in the Ganesh font cache, > which is incorrect. This change ensures that they will have different entries. > > Committed: https://skia.googlesource.com/skia/+/8dc58edd71c11f232860724dfa3b566895478034 TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/1a5041e446bda33e7f5e18f0df8d0be77c0a2349

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -34 lines)			Patch
M	src/gpu/GrBitmapTextContext.cpp	View	6 chunks	+6 lines, -11 lines	0 comments	Download
M	src/gpu/GrDistanceFieldTextContext.cpp	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/gpu/GrFontCache.h	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	src/gpu/GrFontCache.cpp	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/gpu/GrGlyph.h	View	3 chunks	+2 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

jvanverth1

Created Revert of Ensure that we use different glyph entries for regular and df text.

5 years, 9 months ago (2015-03-18 22:13:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011403005/1

5 years, 9 months ago (2015-03-18 22:13:56 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-18 22:14:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1a5041e446bda33e7f5e18f0df8d0be77c0a2349