BitmapTextBatch and BitmapTextBlob

src/core/SkTextBlob.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkTextBlob.h"
 
 #include "SkReadBuffer.h"
@@ skipping 92 matching lines @@
     uint32_t         fCount;
     SkPoint          fOffset;
     SkPaint          fFont;
     GlyphPositioning fPositioning;
 
     SkDEBUGCODE(unsigned fMagic;)
 };
 
 SkTextBlob::SkTextBlob(int runCount, const SkRect& bounds)
     : fRunCount(runCount)
-    , fBounds(bounds) {
+    , fBounds(bounds)
+    , fUniqueID(SK_InvalidGenID) {
 }
 
 SkTextBlob::~SkTextBlob() {
     const RunRecord* run = RunRecord::First(this);
     for (int i = 0; i < fRunCount; ++i) {
         const RunRecord* nextRun = RunRecord::Next(run);
         SkDEBUGCODE(run->validate((uint8_t*)this + fStorageSize);)
         run->~RunRecord();
         run = nextRun;
     }
 }
 
 uint32_t SkTextBlob::uniqueID() const {

[bsalomon, 2015/03/24 16:27:53]

Is it really worth populating this lazily? I know we don't in several other
classes that maintain unique ids.

[joshualitt, 2015/03/25 14:13:37]

I have another CL out which addresses this

     static int32_t  gTextBlobGenerationID; // = 0;
 
     // loop in case our global wraps around, as we never want to return SK_InvalidGenID
     while (SK_InvalidGenID == fUniqueID) {
         fUniqueID = sk_atomic_inc(&gTextBlobGenerationID) + 1;
     }
 
     return fUniqueID;
 }
 
@@ skipping 399 matching lines @@
 
     fStorageUsed = 0;
     fStorageSize = 0;
     fRunCount = 0;
     fLastRun = 0;
     fBounds.setEmpty();
 
     return blob;
 }