Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1011403003: cps-ir: Set runtime type information for new objects that require it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add parameter for each type variable to the JS-factory. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
index bdacd015367b857e01c2152b372cbf76ea9f7d32..28562b12f9822ff942b055bc31d109b09fc1df01 100644
--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
@@ -777,7 +777,7 @@ class _TypePropagationVisitor<T> implements Visitor {
// Continuations on the other hand are local, and parameters can have
// some other abstract value than non-constant.
} else {
- internalError(node.hint, "Unexpected parent of Parameter");
+ internalError(node.hint, "Unexpected parent of Parameter: ${node.parent}");
}
}
@@ -854,6 +854,13 @@ class _TypePropagationVisitor<T> implements Visitor {
// real constants of type [Type].
setValue(node, nonConst());
}
+
+ @override
+ visitTypeExpression(TypeExpression node) {
+ // TODO(karlklose): come up with a type marker for JS entities or switch to
+ // real constants of type [Type].
+ setValue(node, nonConst());
+ }
}
/// Represents the abstract value of a primitive value at some point in the

Powered by Google App Engine
This is Rietveld 408576698