Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1011403003: cps-ir: Set runtime type information for new objects that require it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
index 5bea4f56c43e50770fe56115fc6dc760d2e59db7..ad6a31e246209b973ab3d61c587ad5af438642b6 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
@@ -381,11 +381,12 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {
}
String visitInvokeConstructor(InvokeConstructor node) {
+ String className = node.target.enclosingClass.name;
String callName;
if (node.target.name.isEmpty) {
- callName = '${node.type}';
+ callName = '${className}';
} else {
- callName = '${node.type}.${node.target.name}';
+ callName = '${className}.${node.target.name}';
}
String args = formatArguments(node);
String keyword = node.constant != null ? 'const' : 'new';
@@ -495,12 +496,17 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {
@override
String visitReadTypeVariable(ReadTypeVariable node) {
- return 'read ${node.variable.element} ${visitExpression(node.target)}';
+ return 'Read ${node.variable.element} ${visitExpression(node.target)}';
}
@override
String visitReifyRuntimeType(ReifyRuntimeType node) {
- return 'reify ${node.value}';
+ return 'Reify ${node.value}';
+ }
+
+ @override
+ String visitTypeExpression(TypeExpression node) {
+ return node.dartType.toString();
}
}
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart ('k') | tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698