Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1011403003: cps-ir: Set runtime type information for new objects that require it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index 74c4b1ccd050593c8de79e009a4b5f1589b5df78..d3668a872038550d3c54dfd16e757ffc0c0b5302 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -182,11 +182,12 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitInvokeConstructor(cps_ir.InvokeConstructor node) {
String dummy = names.name(node);
+ String className = node.target.enclosingClass.name;
String callName;
if (node.target.name.isEmpty) {
- callName = '${node.type}';
+ callName = '${className}';
} else {
- callName = '${node.type}.${node.target.name}';
+ callName = '${className}.${node.target.name}';
}
String args = node.arguments.map(formatReference).join(', ');
String kont = formatReference(node.continuation);
@@ -308,7 +309,9 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitCreateInstance(cps_ir.CreateInstance node) {
String className = node.classElement.name;
String arguments = node.arguments.map(formatReference).join(', ');
- return 'CreateInstance $className ($arguments)';
+ String typeInformation = node.hasTypeInformation
+ ? ' ${node.typeInformation.map(formatReference).join(', ')}' : '';
+ return 'CreateInstance $className ($arguments)$typeInformation';
}
visitIdentical(cps_ir.Identical node) {
@@ -344,6 +347,12 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitReifyRuntimeType(cps_ir.ReifyRuntimeType node) {
return "ReifyRuntimeType ${formatReference(node.value)}";
}
+
+ @override
+ visitTypeExpression(cps_ir.TypeExpression node) {
+ return "TypeExpression ${node.dartType} "
+ "${node.arguments.map(formatReference).join(', ')}";
+ }
}
/**
@@ -588,4 +597,9 @@ class BlockCollector implements cps_ir.Visitor {
visitReifyRuntimeType(cps_ir.ReifyRuntimeType node) {
unexpectedNode(node);
}
+
+ @override
+ visitTypeExpression(cps_ir.TypeExpression node) {
+ unexpectedNode(node);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698