cps-ir: Set runtime type information for new objects that require it.

pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.ir_nodes_sexpr;
 
 import '../constants/values.dart';
 import '../util/util.dart';
 import 'cps_ir_nodes.dart';
 
@@ skipping 180 matching lines @@
 
   String visitInvokeMethodDirectly(InvokeMethodDirectly node) {
     String receiver = access(node.receiver);
     String name = node.selector.name;
     String cont = access(node.continuation);
     String args = formatArguments(node);
     return '$indentation(InvokeMethodDirectly $receiver $name $args $cont)';
   }
 
   String visitInvokeConstructor(InvokeConstructor node) {
+    String className;
+    // TODO(karlklose): for illegal nodes constructed for tests or unresolved
+    // cosntructor calls in the DartBackend, we get an element with no enclosing
+    // class.  Clean this up by introducing a name field to the node and
+    // removing [ErroneousElement]s from the IR.
+    if (node.type != null) {
+      className = node.type.toString();
+    } else {
+      className = node.target.enclosingClass.name;
+    }
     String callName;
     if (node.target.name.isEmpty) {
-      callName = '${node.type}';
+      callName = '${className}';
     } else {
-      callName = '${node.type}.${node.target.name}';
+      callName = '${className}.${node.target.name}';
     }
     String cont = access(node.continuation);
     String args = formatArguments(node);
-    return '$indentation(InvokeConstructor $callName $args $cont)';
+    String typeArguments = node.typeArguments.isEmpty ? ''
+        : ' <${node.typeArguments.map(access).join(', ')}>';
+    return '$indentation(InvokeConstructor $callName $args$typeArguments'
+        ' $cont)';
   }
 
   String visitConcatenateStrings(ConcatenateStrings node) {
     String cont = access(node.continuation);
     String args = node.arguments.map(access).join(' ');
     return '$indentation(ConcatenateStrings ($args) $cont)';
   }
 
   String visitInvokeContinuation(InvokeContinuation node) {
     String name = access(node.continuation);
@@ skipping 111 matching lines @@
     return '(Interceptor ${access(node.input)})';
   }
 
   String visitReifyRuntimeType(ReifyRuntimeType node) {
     return '(ReifyRuntimeType ${access(node.value)})';
   }
 
   String visitReadTypeVariable(ReadTypeVariable node) {
     return '(ReadTypeVariable ${access(node.target)}.${node.variable})';
   }
+
+  @override
+  String visitTypeExpression(TypeExpression node) {
+    String args = node.arguments.map(access).join(', ');
+    return '(TypeExpression ${node.dartType.toString()} $args)';

[asgerf, 2015/03/18 10:18:06]

Redundant toString call

+  }
 }
 
 class ConstantStringifier extends ConstantValueVisitor<String, Null> {
   // Some of these methods are unimplemented because we haven't had a need
   // to print such constants.  When printing is implemented, the corresponding
   // parsing support should be added to SExpressionUnstringifier.parseConstant
   // in the dart2js tests (currently in the file
   // tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart).
 
   String _failWith(ConstantValue constant) {
@@ skipping 89 matching lines @@
   void setReturnContinuation(Continuation node) {
     assert(!_names.containsKey(node) || _names[node] == 'return');
     _names[node] = 'return';
   }
 
   String getName(Node node) {
     assert(_names.containsKey(node));
     return _names[node];
   }
 }