Fast NTP support for themes, dark themes, favicons.

chrome/browser/resources/local_ntp/local_ntp_fast.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileoverview The local InstantExtended NTP.
  */
 
 
@@ skipping 166 matching lines @@
 /**
  * Minimum total padding to give to the left and right of the most visited
  * section. Used to determine how many tiles to show.
  * @type {number}
  * @const
  */
 var MIN_TOTAL_HORIZONTAL_PADDING = 200;
 
 
 /**
- * The color of the title in RRGGBBAA format.
- * @type {?string}
- */
-var titleColor = null;
-
-
-/**
  * Heuristic to determine whether a theme should be considered to be dark, so
  * the colors of various UI elements can be adjusted.
  * @param {ThemeBackgroundInfo|undefined} info Theme background information.
  * @return {boolean} Whether the theme is dark.
  * @private
  */
 function getIsThemeDark(info) {
   if (!info)
     return false;
   // Heuristic: light text implies dark theme.
@@ skipping 14 matching lines @@
     if (configData.translatedStrings.searchboxPlaceholder) {
       fakeboxText.textContent =
           configData.translatedStrings.searchboxPlaceholder;
     }
   }
 
   var info = ntpApiHandle.themeBackgroundInfo;
   var isThemeDark = getIsThemeDark(info);
   ntpContents.classList.toggle(CLASSES.DARK, isThemeDark);
   if (!info) {
-    titleColor = NTP_DESIGN.titleColor;
     return;
   }
 
-  if (!info.usingDefaultTheme && info.textColorRgba) {
-    titleColor = convertToRRGGBBAAColor(info.textColorRgba);
-  } else {
-    titleColor = isThemeDark ?
-        NTP_DESIGN.titleColorAgainstDark : NTP_DESIGN.titleColor;
-  }
-
   var background = [convertToRGBAColor(info.backgroundColorRgba),
                     info.imageUrl,
                     info.imageTiling,
                     info.imageHorizontalAlignment,
                     info.imageVerticalAlignment].join(' ').trim();
 
   document.body.style.background = background;
   document.body.classList.toggle(CLASSES.ALTERNATE_LOGO, info.alternateLogo);
   updateThemeAttribution(info.attributionUrl);
   setCustomThemeStyle(info);
+
+  var themeinfo = {cmd: 'updateTheme'};
+  if (!info.usingDefaultTheme) {
+    themeinfo.tileBorderColor = convertToRGBAColor(info.sectionBorderColorRgba);
+    themeinfo.tileHoverBorderColor = convertToRGBAColor(info.headerColorRgba);
+  }
+  themeinfo.isThemeDark = isThemeDark;
+
+  var titleColor = NTP_DESIGN.titleColor;
+  if (!info.usingDefaultTheme && info.textColorRgba) {
+    titleColor = convertToRRGGBBAAColor(info.textColorRgba);

[huangs, 2015/03/19 23:45:01]

Sorry should have caught this, too: Just assign 
  title = info.textColorRgba;
Can get rid of convertToRRGGBBAAColor(). Some context: in the past we injected
RRGGBB to title iframe to render its text (choosable by local NTP), and if
absent then it grabbed theme by itself.  When doing Material Design I decided to
favor injection (query params).  To not break existing 3rd party NTPs, I kept
the old behavior, but used RRGGBBAA to do the new behavior.

Anyway we don't need this now.

+  } else if (isThemeDark) {
+    NTP_DESIGN.titleColorAgainstDark;

[huangs, 2015/03/19 23:45:01]

Assign to titleColor.

+  }
+  themeinfo.tileTitleColor = convertToRGBAColor(titleColor);
+
+  $('mv-single').contentWindow.postMessage(themeinfo, '*');
 }
 
 
 /**
  * Updates the NTP based on the current theme, then rerenders all tiles.
  * @private
  */
 function onThemeChange() {
   renderTheme();
 }
@@ skipping 437 matching lines @@
   ntpApiHandle = topLevelHandle.newTabPage;
   ntpApiHandle.onthemechange = onThemeChange;
   ntpApiHandle.onmostvisitedchange = onMostVisitedChange;
 
   ntpApiHandle.oninputstart = onInputStart;
   ntpApiHandle.oninputcancel = restoreNtp;
 
   if (ntpApiHandle.isInputInProgress)
     onInputStart();
 
-  renderTheme();
-
   searchboxApiHandle = topLevelHandle.searchBox;
 
   if (fakebox) {
     // Listener for updating the key capture state.
     document.body.onmousedown = function(event) {
       if (isFakeboxClick(event))
         searchboxApiHandle.startCapturingKeyStrokes();
       else if (isFakeboxFocused())
         searchboxApiHandle.stopCapturingKeyStrokes();
     };
@@ skipping 45 matching lines @@
   }
 
   args.push('removeTooltip=' +
       encodeURIComponent(configData.translatedStrings.removeThumbnailTooltip));
 
   iframe.src = '//most-visited/single.html?' + args.join('&');
   $(IDS.TILES).appendChild(iframe);
 
   iframe.onload = function() {
     reloadTiles();
+    renderTheme();
   };
 
   window.addEventListener('message', handlePostMessage);
 }
 
 
 /**
  * Binds event listeners.
  */
 function listen() {
   document.addEventListener('DOMContentLoaded', init);
 }
 
 return {
   init: init,
   listen: listen
 };
 }
 
 if (!window.localNTPUnitTest) {
   LocalNTP().listen();
 }