Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1011393003: [S.P.] Invalidate the document element for view background when needed (Closed)

Created:
5 years, 9 months ago by Xianzhu
Modified:
5 years, 9 months ago
Reviewers:
chrishtr, pdr., trchen
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[S.P.] Invalidate the document element for view background when needed The document element draws the background of the view even if it has no specified background and/or the background is specified on <body>. Let LayoutObject::skipInvalidationWhenLaidOutChildren() return false for document element before checking rendererHasNoBoxEffect(). BUG=468373 TEST=some virtual/slimmingpaint/fast/repaint tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192195

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix rendererHasNoBoxEffect() and TestExpectations #

Total comments: 2

Patch Set 3 : Another NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/resources/window-resize-repaint.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.h View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
Xianzhu
5 years, 9 months ago (2015-03-18 19:16:26 UTC) #2
chrishtr
https://codereview.chromium.org/1011393003/diff/1/LayoutTests/fast/repaint/resources/window-resize-repaint.js File LayoutTests/fast/repaint/resources/window-resize-repaint.js (right): https://codereview.chromium.org/1011393003/diff/1/LayoutTests/fast/repaint/resources/window-resize-repaint.js#newcode34 LayoutTests/fast/repaint/resources/window-resize-repaint.js:34: repaintRects += internals.layerTreeAsText(document, window.internals.LAYER_TREE_INCLUDES_REPAINT_RECTS | window.internals.LAYER_TREE_INCLUDES_PAINT_INVALIDATION_OBJECTS); But it doesn't ...
5 years, 9 months ago (2015-03-18 19:30:05 UTC) #3
Xianzhu
https://codereview.chromium.org/1011393003/diff/1/LayoutTests/fast/repaint/resources/window-resize-repaint.js File LayoutTests/fast/repaint/resources/window-resize-repaint.js (right): https://codereview.chromium.org/1011393003/diff/1/LayoutTests/fast/repaint/resources/window-resize-repaint.js#newcode34 LayoutTests/fast/repaint/resources/window-resize-repaint.js:34: repaintRects += internals.layerTreeAsText(document, window.internals.LAYER_TREE_INCLUDES_REPAINT_RECTS | window.internals.LAYER_TREE_INCLUDES_PAINT_INVALIDATION_OBJECTS); On 2015/03/18 19:30:05, ...
5 years, 9 months ago (2015-03-18 19:36:28 UTC) #4
Xianzhu
I can try to refactor our painting code to let LayoutView (instead of the document ...
5 years, 9 months ago (2015-03-18 22:44:19 UTC) #5
chrishtr
Some of the rebaselines here look weird: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/52986/layout-test-results/results.html In particular the ones towards the top.
5 years, 9 months ago (2015-03-19 19:45:34 UTC) #6
chrishtr
Nm, I see you didn't list those in TestExpectations.
5 years, 9 months ago (2015-03-19 19:46:18 UTC) #7
chrishtr
lgtm
5 years, 9 months ago (2015-03-19 19:47:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011393003/40001
5 years, 9 months ago (2015-03-19 19:47:34 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 21:04:52 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192195

Powered by Google App Engine
This is Rietveld 408576698