chrome/android/java/res/layout/data_reduction_promo_screen.xml - Issue 1011363006: Data Saver promo changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/data_reduction_promo_screen.xml

Issue 1011363006: Data Saver promo changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/bandwidth/DataReductionPromoScreen.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/bandwidth/DataReductionPromoScreen.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/data_reduction_promo_screen.xml

diff --git a/chrome/android/java/res/layout/data_reduction_promo_screen.xml b/chrome/android/java/res/layout/data_reduction_promo_screen.xml

index 4e2409c092b1293758961078b011e0790e848324..ea500f1e34e99be177e2ab271808cd5547d4d161 100644

--- a/chrome/android/java/res/layout/data_reduction_promo_screen.xml

+++ b/chrome/android/java/res/layout/data_reduction_promo_screen.xml

@@ -45,37 +45,35 @@

android:layout_marginTop="35dp"

android:layout_width="match_parent"

android:orientation="vertical"

- android:paddingStart="40dp"

- android:paddingEnd="40dp">

+ android:paddingStart="20dp"

+ android:paddingEnd="20dp">

<TextView

android:gravity="center"

android:layout_height="wrap_content"

android:layout_width="match_parent"

android:text="@string/data_reduction_title_1"

android:textColor="#000"

- android:textSize="30sp" />

- <TextView

+ android:textSize="28sp" />

+ <org.chromium.ui.widget.TextViewWithClickableSpans

+ android:id="@+id/data_reduction_title_2_link"

android:gravity="center"

android:layout_height="wrap_content"

android:layout_marginTop="20dp"

android:layout_width="match_parent"

android:lineSpacingExtra="20dp"

newt (away) 2015/03/24 21:08:26 use sp instead of dp so this scales when the user

megjablon 2015/03/24 21:23:11 Done.

android:lineSpacingMultiplier="0"

- android:paddingStart="20dp"

- android:paddingEnd="20dp"

- android:text="@string/data_reduction_title_2"

- android:textColor="#969696"

+ android:textColor="#333"

android:textSize="16sp" />

<TextView

android:gravity="center"

android:layout_height="wrap_content"

android:layout_marginTop="20dp"

android:layout_width="match_parent"

- android:lineSpacingExtra="25dp"

+ android:lineSpacingExtra="20dp"

android:lineSpacingMultiplier="0"

android:text="@string/data_reduction_title_3"

- android:textColor="#000"

- android:textSize="20sp" />

+ android:textColor="#333"

+ android:textSize="16sp" />

</LinearLayout>

<ImageView

android:layout_alignParentBottom="true"