[Password manager Python tests] Switch to Python logging

[Password manager Python tests] Switch to Python logging

This CL makes all output of the tests to go through the Python standard logging:
 * script-level debugging messages gets logged on a custom SCRIPT_DEBUG level (9)
 * logs from failed tests get logged at level DEBUG
 * summary of the tests run gets logged at level INFO

This allows to remove the knowledge of how the results are passed on from the test running scripts. In particular, the Google Spreadsheet writing code has been removed. To restore that functionality, the caller of these scripts will need to implement a custom logging handler. That will happen in a separate CL, because the caller is in a separate repository.

BUG=468245
Committed: https://crrev.com/afcdc69633e6c77aaaf684fc5594582af504a379
Cr-Commit-Position: refs/heads/master@{#321338}

[vabr (Chromium), 2015-03-18 15:44:15]

vabr@chromium.org changed reviewers:
+ melandory@chromium.org

[vabr (Chromium), 2015-03-18 15:44:16]

Hi Tanja,

Could you please have a look?
I'll let you know once I also have the internal part ready for review, but this
should make sense even without it.
Apologies for so many changes, I also ran a Python linter on the file, and
addressed its comments.

Thanks!
Vaclav

[melandory, 2015-03-19 10:06:26]

On 2015/03/18 15:44:16, vabr (Chromium) wrote:
> Hi Tanja,
> 
> Could you please have a look?
> I'll let you know once I also have the internal part ready for review, but
this
> should make sense even without it.
> Apologies for so many changes, I also ran a Python linter on the file, and
> addressed its comments.
> 
> Thanks!
> Vaclav

lgtm

[melandory, 2015-03-19 10:06:37]

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:105:
"""Returns True iff the test passed."""
s/iff/if

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:124: with
open(self.results_path, "w"):
Just observation:
in python3 it would be one line:
https://docs.python.org/3/library/os.html#os.truncate
os.truncate(self.result_path)

[vabr (Chromium), 2015-03-19 10:28:40]

vabr@chromium.org changed reviewers:
+ engedy@chromium.org

[vabr (Chromium), 2015-03-19 10:28:41]

Thanks, Tanja!
Comment addressed.

Balázs, could you please give me a committer rubber-stamp? (Tanja's nomination
is in process.)

Thanks,
Vaclav

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:105:
"""Returns True iff the test passed."""
On 2015/03/19 10:06:36, melandory wrote:
> s/iff/if

This was actually intentional (http://en.wikipedia.org/wiki/If_and_only_if), but
I will spell it out fully to avoid confusion.

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:124: with
open(self.results_path, "w"):
On 2015/03/19 10:06:37, melandory wrote:
> Just observation:
> in python3 it would be one line:
> https://docs.python.org/3/library/os.html#os.truncate
> os.truncate(self.result_path)

Acknowledged. Thanks, good to know!

[engedy, 2015-03-19 10:30:10]

Rubberstamp LGTM.

[melandory, 2015-03-19 10:31:08]

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:198: while i
< len(runners):
I'm thinking maybe we can use list comprehension here. Code will be more
understandable. Can you please add TODO for me to rewrite it?

[vabr (Chromium), 2015-03-19 10:40:46]

Thanks Balázs and Tanja.

Requested TODO added, sending to CQ.

Cheers,
Vaclav

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/1011363003/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:198: while i
< len(runners):
On 2015/03/19 10:31:08, melandory wrote:
> I'm thinking maybe we can use list comprehension here. Code will be more
> understandable. Can you please add TODO for me to rewrite it?

With pleasure, thanks for volunteering, Tanja! :)

[vabr (Chromium), 2015-03-19 10:40:50]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2015-03-19 10:40:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
melandory@chromium.org, engedy@chromium.org
Link to the patchset: https://codereview.chromium.org/1011363003/#ps40001
(title: "Added TODO(melandory)")

[commit-bot: I haz the power, 2015-03-19 10:40:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1011363003/40001

[commit-bot: I haz the power, 2015-03-19 11:56:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-19 11:56:59]

Patchset 3 (id:??) landed as
https://crrev.com/afcdc69633e6c77aaaf684fc5594582af504a379
Cr-Commit-Position: refs/heads/master@{#321338}