Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1011363002: Revert of Enable toolkit_views=1 by default on Mac (Closed)

Created:
5 years, 9 months ago by tapted
Modified:
5 years, 9 months ago
Reviewers:
sky, scottmg
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org, Andre
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable toolkit_views=1 by default on Mac (patchset #4 id:210001 of https://codereview.chromium.org/984513002/) Reason for revert: Failing on GN build :(. Link: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/5288 E.g. display_change_listener_aura.cc:38:43:error: member access into incomplete type 'NSView' Original issue's description: > Enable toolkit_views=1 by default on Mac > > As announced on chromium-dev: http://goo.gl/NqrmLk (and after > discussions with chrome-eng-review). > > This CL shouldn't change any user-visible UI, just change the way Chrome > is built on Mac. Soon, we will explore running ui/app_list/views/ on Mac > rather than the (outdated) ui/app_list/cocoa/. > > A ~0.43% sizes regression on Mac is expected with this CL (~652kB > uncompressed). Full details in a doc: http://goo.gl/oHucmf > > With this change, toolkit-views test cases in interactive_ui_tests will > start running on bots. views_unittests will be added to the Mac bots in > a follow-up. > > BUG=363529 > > Committed: https://crrev.com/c11ec57849fd579c7a5559413488c018ea532311 > Cr-Commit-Position: refs/heads/master@{#321075} TBR=sky@chromium.org,scottmg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=363529 Committed: https://crrev.com/c3bdb1c16c88005acdc0f22394a6780e805ae72f Cr-Commit-Position: refs/heads/master@{#321079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/ui.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tapted
Created Revert of Enable toolkit_views=1 by default on Mac
5 years, 9 months ago (2015-03-18 05:16:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011363002/1
5 years, 9 months ago (2015-03-18 05:16:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 05:17:25 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 05:18:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3bdb1c16c88005acdc0f22394a6780e805ae72f
Cr-Commit-Position: refs/heads/master@{#321079}

Powered by Google App Engine
This is Rietveld 408576698