DescriptionRevert of Enable toolkit_views=1 by default on Mac (patchset #4 id:210001 of https://codereview.chromium.org/984513002/)
Reason for revert:
Failing on GN build :(.
Link: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/5288
E.g. display_change_listener_aura.cc:38:43:error: member access into incomplete type 'NSView'
Original issue's description:
> Enable toolkit_views=1 by default on Mac
>
> As announced on chromium-dev: http://goo.gl/NqrmLk (and after
> discussions with chrome-eng-review).
>
> This CL shouldn't change any user-visible UI, just change the way Chrome
> is built on Mac. Soon, we will explore running ui/app_list/views/ on Mac
> rather than the (outdated) ui/app_list/cocoa/.
>
> A ~0.43% sizes regression on Mac is expected with this CL (~652kB
> uncompressed). Full details in a doc: http://goo.gl/oHucmf
>
> With this change, toolkit-views test cases in interactive_ui_tests will
> start running on bots. views_unittests will be added to the Mac bots in
> a follow-up.
>
> BUG=363529
>
> Committed: https://crrev.com/c11ec57849fd579c7a5559413488c018ea532311
> Cr-Commit-Position: refs/heads/master@{#321075}
TBR=sky@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=363529
Committed: https://crrev.com/c3bdb1c16c88005acdc0f22394a6780e805ae72f
Cr-Commit-Position: refs/heads/master@{#321079}
Patch Set 1 #
Created: 5 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|