Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1011343005: Revert of gpu: Measure texture uploads with glTexSubImage2D and glTexImage2D. (Closed)

Created:
5 years, 9 months ago by sullivan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Measure texture uploads with glTexSubImage2D and glTexImage2D. (patchset #2 id:80001 of https://codereview.chromium.org/1022603002/) Reason for revert: This is causing gpu_perftests to fail on android perfbots. See http://crbug.com/468748 Original issue's description: > gpu: Measure texture uploads with glTexSubImage2D and glTexImage2D. > > glTexImage2D and glTexSubImage2D could have different performance > properties. > With this patch we benchmark both of these upload techniques. > > When using glTexSubImage2D the texture storage is specified with > glTexStorage2D when available, or glTexImage2D passing an empty pointer as data. > > BUG=423481 > > Committed: https://crrev.com/1b9c0f6571baefe70dad41d504cbe3136ce41ae4 > Cr-Commit-Position: refs/heads/master@{#321300} TBR=reveman@chromium.org,dcastagna@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=423481 Committed: https://crrev.com/259170b7fdd43ee87754d1ee89e865443c3af561 Cr-Commit-Position: refs/heads/master@{#321350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -89 lines) Patch
M gpu/perftests/texture_upload_perftest.cc View 16 chunks +37 lines, -89 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sullivan
Created Revert of gpu: Measure texture uploads with glTexSubImage2D and glTexImage2D.
5 years, 9 months ago (2015-03-19 13:50:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011343005/1
5 years, 9 months ago (2015-03-19 13:50:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 13:51:43 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:52:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/259170b7fdd43ee87754d1ee89e865443c3af561
Cr-Commit-Position: refs/heads/master@{#321350}

Powered by Google App Engine
This is Rietveld 408576698