Enabling ico decoding with use of png and bmp decoders

tools/dm_flags.py

Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index f05bb22416e0aa67d407b59b753f89309bc07391..83e4ea2103abb222ea53716955a0cfbfebc55476 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -51,6 +51,23 @@ def get_args(bot):
   blacklist.extend('gpu _ PANO_20121023_214540.jpg'.split(' '))
   blacklist.extend('msaa _ PANO_20121023_214540.jpg'.split(' '))
 
+  # Several of the newest version bmps fail on SkImageDecoder
+  blacklist.extend('_ image pal8os2v2.bmp'.split(' '))

[scroggo, 2015/03/24 15:24:42]

Do we also need to blacklist "subset" for these images?

(If they don't fail earlier, they'll fail in buildTileIndex, which we don't
treat as a failure since not all formats support it. But if they fail earlier,
in SkImageDecoder::Factory, DM will treat that as a failure.)

[msarett, 2015/03/24 16:55:07]

Most of them "fail" by creating an image that doesn't look right.  A few fail in
the factory, and I need to add subset for these.

+  blacklist.extend('_ image pal8v4.bmp'.split(' '))
+  blacklist.extend('_ image pal8v5.bmp'.split(' '))
+  blacklist.extend('_ image rgb16-565.bmp'.split(' '))
+  blacklist.extend('_ image rgb16-565pal.bmp'.split(' '))
+  blacklist.extend('_ image rgb32-111110.bmp'.split(' '))
+  blacklist.extend('_ image rgb32bf.bmp'.split(' '))
+  blacklist.extend('_ image rgba32.bmp'.split(' '))
+  blacklist.extend('_ image rgba32abf.bmp'.split(' '))
+  blacklist.extend('_ image rgb24largepal.bmp'.split(' '))
+  blacklist.extend('_ image pal8os2v2-16.bmp'.split(' '))
+  blacklist.extend('_ image pal8oversizepal.bmp'.split(' '))
+
+  # New ico files that fail on SkImageDecoder
+  blacklist.extend('_ image Hopstarter-Mac-Folders-Apple.ico'.split(' '))
+
   # Leon doesn't care about this, so why run it?
   if 'Win' in bot:
     blacklist.extend('_ image _'.split(' '))