Enabling ico decoding with use of png and bmp decoders

dm/DM.cpp

Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index 833af0edbaa267c8ac9be4314a79be0443051e0a..44090ca1ce46ced5406554f5b5bdf8e6d3458440 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -146,7 +146,9 @@ static void push_src(const char* tag, Src* s) {
 static bool codec_supported(const char* ext) {
     // FIXME: Once other versions of SkCodec are available, we can add them to this
     // list (and eventually we can remove this check once they are all supported).
-    return strcmp(ext, "png") == 0 || strcmp(ext, "PNG") == 0;
+    return strcmp(ext, "png") == 0 || strcmp(ext, "PNG") == 0 || 

[scroggo, 2015/03/24 15:24:42]

nit: As we add more, perhaps we should follow the example of gather_srcs down
below:

static const char* const exts[] = {
// all the ones we support so far
};

for (supportedExt : exts) {
  if (strcmp(supportedExt, ext) == 0) {
    return true;
  }
}

return false;


(I think we discovered the above foreach syntax didn't pass all our bots. Not
sure if that's changed with dropping the NaCl bot).

I'd be fine with leaving it as is though, especially since the plan is to remove
this code once we support all of these.

[msarett, 2015/03/24 16:55:07]

I'll make this change with the addition of gif.

+           strcmp(ext, "bmp") == 0 || strcmp(ext, "BMP") == 0 ||
+           strcmp(ext, "ico") == 0 || strcmp(ext, "ICO") == 0;
 }
 
 static void gather_srcs() {