src/codec/SkCodec_libpng.cpp - Issue 1011343003: Enabling ico decoding with use of png and bmp decoders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec_libpng.cpp

Issue 1011343003: Enabling ico decoding with use of png and bmp decoders (Closed) Base URL: https://skia.googlesource.com/skia.git@swizzle

Patch Set: Clean up before public review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec_libpng.cpp

diff --git a/src/codec/SkCodec_libpng.cpp b/src/codec/SkCodec_libpng.cpp

index 57653e74df30b44f379a755a2640f2030b3162a1..b425e70aa47317c8d253ec8aa3b74c668ef39607 100644

--- a/src/codec/SkCodec_libpng.cpp

+++ b/src/codec/SkCodec_libpng.cpp

@@ -188,8 +188,6 @@ SkColorTable* decode_palette(png_structp png_ptr, png_infop info_ptr,

// Creation

///////////////////////////////////////////////////////////////////////////////

-#define PNG_BYTES_TO_CHECK 4

bool SkPngCodec::IsPng(SkStream* stream) {

char buf[PNG_BYTES_TO_CHECK];

if (stream->read(buf, PNG_BYTES_TO_CHECK) != PNG_BYTES_TO_CHECK) {

« src/codec/SkCodec_libico.cpp ('K') | « src/codec/SkCodec_libico.cpp ('k') | no next file » | no next file with comments »