Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: dm/DM.cpp

Issue 1011343003: Enabling ico decoding with use of png and bmp decoders (Closed) Base URL: https://skia.googlesource.com/skia.git@swizzle
Patch Set: Using appropriate Sk data types for array of codecs, removing getOriginalInfo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dm/DMSrcSink.cpp » ('j') | src/codec/SkCodec_libbmp.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index 833af0edbaa267c8ac9be4314a79be0443051e0a..36025abfb38f46ee78611bc3dd254dfdc8cb5b35 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -146,7 +146,7 @@ static void push_src(const char* tag, Src* s) {
static bool codec_supported(const char* ext) {
// FIXME: Once other versions of SkCodec are available, we can add them to this
// list (and eventually we can remove this check once they are all supported).
- return strcmp(ext, "png") == 0 || strcmp(ext, "PNG") == 0;
+ return true;//strcmp(ext, "png") == 0 || strcmp(ext, "PNG") == 0;
msarett 2015/03/23 19:40:02 Not planning to commit this.
scroggo 2015/03/23 20:34:50 Even better would be to add "bmp", "BMP", "ico", "
msarett 2015/03/24 13:08:37 Done.
}
static void gather_srcs() {
« no previous file with comments | « no previous file | dm/DMSrcSink.cpp » ('j') | src/codec/SkCodec_libbmp.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698