Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: shell/switches.cc

Issue 1011333003: Fix races when the same bits are downloaded from 2 URLs. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Follow review Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/switches.h ('k') | sky/tools/skydb » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/switches.cc
diff --git a/shell/switches.cc b/shell/switches.cc
index 43df7cd0e0b2e05c2218f768a385e7b8f0a29ba4..345a42f95bfcd9e850ff9820ba0f6963edffafbc 100644
--- a/shell/switches.cc
+++ b/shell/switches.cc
@@ -32,6 +32,9 @@ const char kContentHandlers[] = "content-handlers";
// instructions.
const char kDisableCache[] = "disable-cache";
+// If set apps downloaded are not deleted.
+const char kDontDeleteOnDownload[] = "dont-delete-on-download";
+
// Allow externally-running applications to discover, connect to, and register
// themselves with the shell.
// TODO(cmasone): Work in progress. Once we're sure this works, remove.
@@ -58,15 +61,19 @@ const char kMapOrigin[] = "map-origin";
// url_resolver.cc for details.
const char kOrigin[] = "origin";
+// If set apps downloaded are saved in with a predictable filename, to help
+// remote debugging: when gdb is used through gdbserver, it needs to be able to
+// find locally any loaded library. For this, gdb use the filename of the
+// library. When using this flag, the application are named with the sha256 of
+// their content.
+const char kPredictableAppFilenames[] = "predictable-app-filenames";
+
// Specifies a set of mappings to apply when resolving urls. The value is a set
// of ',' separated mappings, where each mapping consists of a pair of urls
// giving the to/from url to map. For example, 'a=b,c=d' contains two mappings,
// the first maps 'a' to 'b' and the second 'c' to 'd'.
const char kURLMappings[] = "url-mappings";
-// If set apps downloaded are not deleted.
-const char kDontDeleteOnDownload[] = "dont-delete-on-download";
-
// Switches valid for the main process (i.e., that the user may pass in).
const char* kSwitchArray[] = {kV,
kArgsFor,
@@ -80,6 +87,7 @@ const char* kSwitchArray[] = {kV,
kHelp,
kMapOrigin,
kOrigin,
+ kPredictableAppFilenames,
kURLMappings};
const std::set<std::string> GetAllSwitches() {
« no previous file with comments | « shell/switches.h ('k') | sky/tools/skydb » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698