shell/application_manager/network_fetcher.h - Issue 1011333003: Fix races when the same bits are downloaded from 2 URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: shell/application_manager/network_fetcher.h

Issue 1011333003: Fix races when the same bits are downloaded from 2 URLs. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: shell/application_manager/network_fetcher.h

diff --git a/shell/application_manager/network_fetcher.h b/shell/application_manager/network_fetcher.h

index ff4152724ccbe97ba9c21f9e92255c563098d178..a5ef1541ddb43baac02aacf953200d21bc30e5ff 100644

--- a/shell/application_manager/network_fetcher.h

+++ b/shell/application_manager/network_fetcher.h

@@ -46,7 +46,8 @@ class NetworkFetcher : public Fetcher {

static bool ComputeAppId(const base::FilePath& path,

std::string* digest_string);

- static bool RenameToAppId(const base::FilePath& old_path,

+ static bool RenameToAppId(const GURL& url,

+ const base::FilePath& old_path,

base::FilePath* new_path);

void CopyCompleted(base::Callback<void(const base::FilePath&, bool)> callback,