Fix races when the same bits are downloaded from 2 URLs.

shell/switches.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "shell/switches.h"
 
 #include "base/basictypes.h"
 
 namespace switches {
 
@@ skipping 14 matching lines @@
 const char kChildProcessType[] = "child-process-type";
 
 // Comma separated list like:
 // text/html,mojo:html_viewer,application/bravo,https://abarth.com/bravo
 const char kContentHandlers[] = "content-handlers";
 
 // Force dynamically loaded apps / services to be loaded irrespective of cache
 // instructions.
 const char kDisableCache[] = "disable-cache";
 
+// If set apps downloaded are not deleted.
+const char kDontDeleteOnDownload[] = "dont-delete-on-download";
+
 // Allow externally-running applications to discover, connect to, and register
 // themselves with the shell.
 // TODO(cmasone): Work in progress. Once we're sure this works, remove.
 const char kEnableExternalApplications[] = "enable-external-applications";
 
 // Load apps in separate processes.
 // TODO(vtl): Work in progress; doesn't work. Flip this to "disable" (or maybe
 // change it to "single-process") when it works.
 const char kEnableMultiprocess[] = "enable-multiprocess";
 
 // In multiprocess mode, force these apps to be loaded in the main process.
 // Comma-separate list of URLs. Example:
 // --force-in-process=mojo:native_viewport_service,mojo:network_service
 const char kForceInProcess[] = "force-in-process";
 
 // Print the usage message and exit.
 const char kHelp[] = "help";
 
 // Specify origin to map to base url. See url_resolver.cc for details.
 // Can be used multiple times.
 const char kMapOrigin[] = "map-origin";
 
 // Map mojo: URLs to a shared library of similar name at this origin. See
 // url_resolver.cc for details.
 const char kOrigin[] = "origin";
 
+// If set apps downloaded are saved in with a predictable filename, to help
+// remote debugging.

[Nick Bray (chromium), 2015/03/19 17:45:20]

Comment / crosslink / document.

[qsr, 2015/03/20 11:50:49]

Done.

+const char kPredictableAppFilenames[] = "predictable-app-filenames";
+
 // Specifies a set of mappings to apply when resolving urls. The value is a set
 // of ',' separated mappings, where each mapping consists of a pair of urls
 // giving the to/from url to map. For example, 'a=b,c=d' contains two mappings,
 // the first maps 'a' to 'b' and the second 'c' to 'd'.
 const char kURLMappings[] = "url-mappings";
 
-// If set apps downloaded are not deleted.
-const char kDontDeleteOnDownload[] = "dont-delete-on-download";
-
 // Switches valid for the main process (i.e., that the user may pass in).
 const char* kSwitchArray[] = {kV,
                               kArgsFor,
                               // |kChildProcessType| not for user use.
                               kContentHandlers,
                               kDisableCache,
                               kDontDeleteOnDownload,
                               kEnableExternalApplications,
                               kEnableMultiprocess,
                               kForceInProcess,
                               kHelp,
                               kMapOrigin,
                               kOrigin,
+                              kPredictableAppFilenames,
                               kURLMappings};
 
 const std::set<std::string> GetAllSwitches() {
   std::set<std::string> switch_set;
 
   for (size_t i = 0; i < arraysize(kSwitchArray); ++i)
     switch_set.insert(kSwitchArray[i]);
   return switch_set;
 }
 
 }  // namespace switches