Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1011323003: MacViews: Fix GN build (Closed)

Created:
5 years, 9 months ago by tapted
Modified:
5 years, 9 months ago
Reviewers:
Andre, sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix GN build build/config/BUILDCONFIG.gn explicitly disallows wildcards for things like toolkits, so move _aura* files into aura_sources variables (which mostly already existed). gfx/BUILD.gn needed an update to the condition for nine_image_painter.cc, to be consistent with gfx.gyp. BUG=363529 Committed: https://crrev.com/603d6756583bece8e4ae8d9e8bbb43b5a8d16c07 Cr-Commit-Position: refs/heads/master@{#321144}

Patch Set 1 #

Patch Set 2 : too ambitious #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -52 lines) Patch
M ui/gfx/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 8 chunks +17 lines, -16 lines 0 comments Download
M ui/views/views.gyp View 19 chunks +33 lines, -34 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tapted
Hi sky, please take a look. .. turns out GN on Mac is further along ...
5 years, 9 months ago (2015-03-18 08:31:16 UTC) #4
sky
LGTM
5 years, 9 months ago (2015-03-18 15:01:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011323003/20001
5 years, 9 months ago (2015-03-18 15:58:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 16:06:06 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 16:06:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/603d6756583bece8e4ae8d9e8bbb43b5a8d16c07
Cr-Commit-Position: refs/heads/master@{#321144}

Powered by Google App Engine
This is Rietveld 408576698