Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1011283004: AppList shouldn't be dismissed when an app is uninstalled (Closed)

Created:
5 years, 9 months ago by afakhry
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AppList shouldn't be dismissed when an app is uninstalled When an app is being uninstalled and the "confirm removal" dialog is closed, the focus controller selects the most recently used window to return focus to. However, the MruWindowTracker doesn't take into consideration the app list container, and hence the app list window is not on the MRU window list. Focus is then returned to something else (if you have other windows open) which causes the dismissal of the App list. R=oshima@chromium.org,skuhne@chromium.org BUG=467877 Committed: https://crrev.com/bff9c2f7564000c3b912e18d70780d1a6263680f Cr-Commit-Position: refs/heads/master@{#321276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/switchable_windows.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
afakhry
@Oshima: Can you please review 'switchable_windows.cc'? @Skuhne: Can you please review 'shelf_layout_manager_unittest.cc'? As per Kuscher@, ...
5 years, 9 months ago (2015-03-18 21:47:53 UTC) #2
Mr4D (OOO till 08-26)
lgtm for unit test
5 years, 9 months ago (2015-03-18 22:46:54 UTC) #3
oshima
lgtm
5 years, 9 months ago (2015-03-18 22:49:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011283004/1
5 years, 9 months ago (2015-03-19 00:54:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 02:43:03 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 02:44:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bff9c2f7564000c3b912e18d70780d1a6263680f
Cr-Commit-Position: refs/heads/master@{#321276}

Powered by Google App Engine
This is Rietveld 408576698