Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 101123004: Disable tracking of double fields during snapshot creation. (Closed)

Created:
7 years ago by ulan
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Disable tracking of double fields during snapshot creation. Follow-up to r18298. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18909

Patch Set 1 #

Patch Set 2 : Restore flag afterwards. #

Patch Set 3 : Remove flag from DoStoreNamedField #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ulan
PTAL
7 years ago (2013-12-11 13:28:37 UTC) #1
Toon Verwaest
Could you please turn it on again after the serializer finishes?
7 years ago (2013-12-11 13:59:22 UTC) #2
ulan
> Could you please turn it on again after the serializer finishes? Done.
7 years ago (2013-12-11 14:13:01 UTC) #3
Toon Verwaest
Nice. LGTM.
7 years ago (2013-12-11 14:14:48 UTC) #4
ulan
PTAL, I removed double field tracking flag from StoreNamedField too.
6 years, 10 months ago (2014-01-28 16:55:25 UTC) #5
Toon Verwaest
Makes sense, lgtm
6 years, 10 months ago (2014-01-28 17:30:53 UTC) #6
ulan
6 years, 10 months ago (2014-01-29 14:19:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r18909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698