Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1011173003: x11: Use gfx::XScopedPtr<> in more places. (Closed)

Created:
5 years, 9 months ago by sadrul
Modified:
5 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

x11: Use gfx::XScopedPtr<> in more places. Instead of manually managing the X11 objects, use the convenient XScopedPtr<> where possible. BUG=none R=oshima@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/14576e72b587c577d60d88ba2929ae7490870c3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -60 lines) Patch
M ui/display/chromeos/x11/native_display_delegate_x11.h View 3 chunks +10 lines, -5 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 5 chunks +8 lines, -15 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 3 chunks +11 lines, -16 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 7 chunks +11 lines, -18 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sadrul
5 years, 9 months ago (2015-03-18 19:58:38 UTC) #2
oshima
nice, lgtm ++
5 years, 9 months ago (2015-03-18 20:24:02 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/14576e72b587c577d60d88ba2929ae7490870c3e Cr-Commit-Position: refs/heads/master@{#321220}
5 years, 9 months ago (2015-03-18 22:18:17 UTC) #4
sadrul
5 years, 9 months ago (2015-03-18 22:18:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14576e72b587c577d60d88ba2929ae7490870c3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698