ppapi/proxy/pdf_resource.cc - Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/pdf_resource.cc

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix missing #ifdef in V8Initializer::Initialize. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/pdf_resource.cc

diff --git a/ppapi/proxy/pdf_resource.cc b/ppapi/proxy/pdf_resource.cc

index e9d3ae893d718db7ffd8e0041c97a6802cf8c298..384fdc90a35bd218251ee1356a79d50e081e87b9 100644

--- a/ppapi/proxy/pdf_resource.cc

+++ b/ppapi/proxy/pdf_resource.cc

@@ -10,7 +10,7 @@

#include "base/command_line.h"

#include "base/metrics/histogram.h"

#include "base/strings/utf_string_conversions.h"

-#include "gin/public/isolate_holder.h"

+#include "gin/v8_initializer.h"

#include "ppapi/c/pp_errors.h"

#include "ppapi/c/private/ppb_pdf.h"

#include "ppapi/proxy/ppapi_messages.h"

@@ -210,8 +210,8 @@ void PDFResource::GetV8ExternalSnapshotData(const char** natives_data_out,

int* natives_size_out,

const char** snapshot_data_out,

int* snapshot_size_out) {

- gin::IsolateHolder::GetV8ExternalSnapshotData(natives_data_out,

- natives_size_out, snapshot_data_out, snapshot_size_out);

+ gin::V8Initializer::GetV8ExternalSnapshotData(

+ natives_data_out, natives_size_out, snapshot_data_out, snapshot_size_out);

}

} // namespace proxy

« no previous file with comments | « net/proxy/proxy_resolver_v8.cc ('k') | no next file » | no next file with comments »