gin/shell_runner_unittest.cc - Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/shell_runner_unittest.cc

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix missing #ifdef in V8Initializer::Initialize. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/shell_runner_unittest.cc

diff --git a/gin/shell_runner_unittest.cc b/gin/shell_runner_unittest.cc

index 7134de16dc72ecc94fe96541b3182832904642ec..340b673362f44dbc5e9155374d1d2386af9a9354 100644

--- a/gin/shell_runner_unittest.cc

+++ b/gin/shell_runner_unittest.cc

@@ -8,6 +8,7 @@

#include "gin/array_buffer.h"

#include "gin/converter.h"

#include "gin/public/isolate_holder.h"

+#include "gin/v8_initializer.h"

#include "testing/gtest/include/gtest/gtest.h"

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

@@ -25,7 +26,7 @@ TEST(RunnerTest, Run) {

std::string source = "this.result = 'PASS';\n";

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

- gin::IsolateHolder::LoadV8Snapshot();

+ gin::V8Initializer::LoadV8Snapshot();

#endif

gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,

« no previous file with comments | « gin/shell/gin_main.cc ('k') | gin/test/file_runner.cc » ('j') | no next file with comments »