components/pdf/renderer/ppb_pdf_impl.cc - Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/pdf/renderer/ppb_pdf_impl.cc

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix missing #ifdef in V8Initializer::Initialize. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/pdf/renderer/ppb_pdf_impl.cc

diff --git a/components/pdf/renderer/ppb_pdf_impl.cc b/components/pdf/renderer/ppb_pdf_impl.cc

index 6349543b717d6911c730e5c37b6249a5dc85bc48..3553c471b7e3267f430bde536e7196aefc9e33b8 100644

--- a/components/pdf/renderer/ppb_pdf_impl.cc

+++ b/components/pdf/renderer/ppb_pdf_impl.cc

@@ -18,7 +18,7 @@

#include "content/public/renderer/pepper_plugin_instance.h"

#include "content/public/renderer/render_thread.h"

#include "content/public/renderer/render_view.h"

-#include "gin/public/isolate_holder.h"

+#include "gin/v8_initializer.h"

#include "ppapi/c/pp_resource.h"

#include "ppapi/c/private/ppb_pdf.h"

#include "ppapi/c/trusted/ppb_browser_font_trusted.h"

@@ -343,8 +343,8 @@ void GetV8ExternalSnapshotData(PP_Instance instance_id,

int* natives_size_out,

const char** snapshot_data_out,

int* snapshot_size_out) {

- gin::IsolateHolder::GetV8ExternalSnapshotData(natives_data_out,

- natives_size_out, snapshot_data_out, snapshot_size_out);

+ gin::V8Initializer::GetV8ExternalSnapshotData(

+ natives_data_out, natives_size_out, snapshot_data_out, snapshot_size_out);

}

const PPB_PDF ppb_pdf = { //

« no previous file with comments | « chrome/plugin/chrome_content_plugin_client.cc ('k') | content/app/DEPS » ('j') | no next file with comments »