net/proxy/proxy_resolver_v8.cc - Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_v8.cc

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate review comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_resolver_v8.cc

diff --git a/net/proxy/proxy_resolver_v8.cc b/net/proxy/proxy_resolver_v8.cc

index 57d68b5d8f9af105ff66644307665e74b9dffe31..21a9e3a5881b2ed51e4ab90b701a35559c59be88 100644

--- a/net/proxy/proxy_resolver_v8.cc

+++ b/net/proxy/proxy_resolver_v8.cc

@@ -18,6 +18,7 @@

#include "base/synchronization/lock.h"

#include "gin/array_buffer.h"

#include "gin/public/isolate_holder.h"

+#include "gin/v8_initializer.h"

#include "net/base/net_errors.h"

#include "net/base/net_log.h"

#include "net/base/net_util.h"

@@ -365,7 +366,7 @@ class SharedIsolateFactory {

// Do one-time initialization for V8.

if (!has_initialized_v8_) {

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

- gin::IsolateHolder::LoadV8Snapshot();

+ gin::V8Initializer::LoadV8Snapshot();

#endif

gin::IsolateHolder::Initialize(

« gin/v8_initializer.h ('K') | « gin/v8_initializer.cc ('k') | ppapi/proxy/pdf_resource.cc » ('j') | no next file with comments »