Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/BUILD.gn

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate review comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/test_blink_web_unit_test_support.cc ('k') | gin/gin.gyp » ('j') | gin/isolate_holder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/BUILD.gn
diff --git a/gin/BUILD.gn b/gin/BUILD.gn
index 5446d56083005fc63048a5e77b09d2b8c32e09c7..9fe5a12756c6b82d3ffaf70af9d28e156fc36c0e 100644
--- a/gin/BUILD.gn
+++ b/gin/BUILD.gn
@@ -56,6 +56,8 @@ component("gin") {
"shell_runner.h",
"try_catch.cc",
"try_catch.h",
+ "v8_initializer.cc",
+ "v8_initializer.h",
"v8_platform.cc",
"wrappable.cc",
"wrappable.h",
« no previous file with comments | « content/test/test_blink_web_unit_test_support.cc ('k') | gin/gin.gyp » ('j') | gin/isolate_holder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698