content/test/content_test_launcher.cc - Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/content_test_launcher.cc

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate review comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/content_test_launcher.cc

diff --git a/content/test/content_test_launcher.cc b/content/test/content_test_launcher.cc

index 7c7eb27b9da3f80206c80bab3499f0db621fca8c..9b30fdb74cf22c4c4a673029817747c018d30469 100644

--- a/content/test/content_test_launcher.cc

+++ b/content/test/content_test_launcher.cc

@@ -21,7 +21,7 @@

#include "testing/gtest/include/gtest/gtest.h"

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

-#include "gin/public/isolate_holder.h"

+#include "gin/v8_initializer.h"

#endif

#if defined(OS_ANDROID)

@@ -57,7 +57,7 @@ class ContentBrowserTestSuite : public ContentTestSuiteBase {

base::i18n::InitializeICU();

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

- gin::IsolateHolder::LoadV8Snapshot();

+ gin::V8Initializer::LoadV8Snapshot();

#endif

// This needs to be done before base::TestSuite::Initialize() is called,

« no previous file with comments | « content/test/DEPS ('k') | content/test/test_blink_web_unit_test_support.cc » ('j') | gin/isolate_holder.cc » ('J')