Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}.

gin/v8_startup_data.cc

Index: gin/v8_startup_data.cc
diff --git a/gin/isolate_holder.cc b/gin/v8_startup_data.cc
similarity index 60%
copy from gin/isolate_holder.cc
copy to gin/v8_startup_data.cc
index 317b5822bd8f47f773a0927d1a2b18ef6c2ebcb8..c6a245aade92b3fe38d212a052938fa4923c357c 100644
--- a/gin/isolate_holder.cc
+++ b/gin/v8_startup_data.cc
@@ -2,24 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "gin/public/isolate_holder.h"
-
-#include <stdlib.h>
-#include <string.h>
-
+#include "base/basictypes.h"
+#include "base/files/file.h"
+#include "base/files/file_path.h"
 #include "base/files/memory_mapped_file.h"
-#include "base/logging.h"

[rmcilroy, 2015/03/26 10:50:08]

You should have base/logging.h I think

[oth, 2015/03/30 09:42:00]

Done.

-#include "base/message_loop/message_loop.h"
-#include "base/rand_util.h"
-#include "base/strings/sys_string_conversions.h"
-#include "base/sys_info.h"
-#include "crypto/sha2.h"

[rmcilroy, 2015/03/26 10:50:08]

I think you still need this for VerifyV8SnapshotFile

-#include "gin/array_buffer.h"
-#include "gin/debug_impl.h"
-#include "gin/function_template.h"
-#include "gin/per_isolate_data.h"
-#include "gin/public/v8_platform.h"
-#include "gin/run_microtasks_observer.h"
 
 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
 #if defined(OS_MACOSX)
@@ -28,17 +14,13 @@
 #include "base/path_service.h"
 #endif  // V8_USE_EXTERNAL_STARTUP_DATA
 
+#include "gin/v8_startup_data.h"

[rmcilroy, 2015/03/26 10:50:08]

put this header at the very top (with a newline after it before the other
includes)

[oth, 2015/03/30 09:42:00]

Done.

+#include "v8/include/v8.h"

[rmcilroy, 2015/03/26 10:50:08]

group with other non-ifdefed includes

[oth, 2015/03/30 09:42:00]

Done.

+
 namespace gin {
 
 namespace {
 
-v8::ArrayBuffer::Allocator* g_array_buffer_allocator = NULL;
-
-bool GenerateEntropy(unsigned char* buffer, size_t amount) {
-  base::RandBytes(buffer, amount);
-  return true;
-}
-
 base::MemoryMappedFile* g_mapped_natives = NULL;
 base::MemoryMappedFile* g_mapped_snapshot = NULL;
 
@@ -118,7 +100,7 @@ extern const unsigned char g_snapshot_fingerprint[];
 #endif  // V8_VERIFY_EXTERNAL_STARTUP_DATA
 
 #if !defined(OS_MACOSX)
-const int IsolateHolder::kV8SnapshotBasePathKey =
+const int V8StartupData::kV8SnapshotBasePathKey =
 #if defined(OS_ANDROID)
     base::DIR_ANDROID_APP_DATA;
 #elif defined(OS_POSIX)
@@ -128,11 +110,27 @@ const int IsolateHolder::kV8SnapshotBasePathKey =
 #endif  // OS_ANDROID
 #endif  // !OS_MACOSX
 
-const char IsolateHolder::kNativesFileName[] = "natives_blob.bin";
-const char IsolateHolder::kSnapshotFileName[] = "snapshot_blob.bin";
+const char V8StartupData::kNativesFileName[] = "natives_blob.bin";
+const char V8StartupData::kSnapshotFileName[] = "snapshot_blob.bin";
+
+// static
+void V8StartupData::GetV8ExternalSnapshotData(const char** natives_data_out,
+                                              int* natives_size_out,
+                                              const char** snapshot_data_out,
+                                              int* snapshot_size_out) {
+  if (!g_mapped_natives || !g_mapped_snapshot) {
+    *natives_data_out = *snapshot_data_out = NULL;
+    *natives_size_out = *snapshot_size_out = 0;
+    return;
+  }
+  *natives_data_out = reinterpret_cast<const char*>(g_mapped_natives->data());
+  *snapshot_data_out = reinterpret_cast<const char*>(g_mapped_snapshot->data());
+  *natives_size_out = static_cast<int>(g_mapped_natives->length());
+  *snapshot_size_out = static_cast<int>(g_mapped_snapshot->length());
+}
 
 // static
-bool IsolateHolder::LoadV8Snapshot() {
+bool V8StartupData::LoadV8Snapshot() {
   if (g_mapped_natives && g_mapped_snapshot)
     return true;
 
@@ -143,15 +141,15 @@ bool IsolateHolder::LoadV8Snapshot() {
 
   base::FilePath natives_path = data_path.AppendASCII(kNativesFileName);
   base::FilePath snapshot_path = data_path.AppendASCII(kSnapshotFileName);
-#else  // !defined(OS_MACOSX)
+#else   // !defined(OS_MACOSX)

[rmcilroy, 2015/03/26 10:50:08]

nit - drop extra whitespace

[oth, 2015/03/30 09:42:00]

Done.

   base::ScopedCFTypeRef<CFStringRef> natives_file_name(
       base::SysUTF8ToCFStringRef(kNativesFileName));
-  base::FilePath natives_path = base::mac::PathForFrameworkBundleResource(
-      natives_file_name);
+  base::FilePath natives_path =
+      base::mac::PathForFrameworkBundleResource(natives_file_name);
   base::ScopedCFTypeRef<CFStringRef> snapshot_file_name(
       base::SysUTF8ToCFStringRef(kSnapshotFileName));
-  base::FilePath snapshot_path = base::mac::PathForFrameworkBundleResource(
-      snapshot_file_name);
+  base::FilePath snapshot_path =
+      base::mac::PathForFrameworkBundleResource(snapshot_file_name);
   DCHECK(!natives_path.empty());
   DCHECK(!snapshot_path.empty());
 #endif  // !defined(OS_MACOSX)
@@ -167,13 +165,13 @@ bool IsolateHolder::LoadV8Snapshot() {
 #endif  // V8_VERIFY_EXTERNAL_STARTUP_DATA
 }
 
-//static
-bool IsolateHolder::LoadV8SnapshotFd(int natives_fd,
-                               int64 natives_offset,
-                               int64 natives_size,
-                               int snapshot_fd,
-                               int64 snapshot_offset,
-                               int64 snapshot_size) {
+// static
+bool V8StartupData::LoadV8SnapshotFromFile(base::PlatformFile natives_fd,
+                                           int64 natives_offset,
+                                           int64 natives_size,
+                                           base::PlatformFile snapshot_fd,
+                                           int64 snapshot_offset,
+                                           int64 snapshot_size) {
   if (g_mapped_natives && g_mapped_snapshot)
     return true;
 
@@ -191,86 +189,12 @@ bool IsolateHolder::LoadV8SnapshotFd(int natives_fd,
         base::MemoryMappedFile::Region(snapshot_offset, snapshot_size);
   }
 
-  return MapV8Files(
-      NULL, NULL, natives_fd, snapshot_fd, natives_region, snapshot_region);
-}
-#endif  // V8_USE_EXTERNAL_STARTUP_DATA
-
-//static
-void IsolateHolder::GetV8ExternalSnapshotData(const char** natives_data_out,
-                                              int* natives_size_out,
-                                              const char** snapshot_data_out,
-                                              int* snapshot_size_out) {
-  if (!g_mapped_natives || !g_mapped_snapshot) {
-    *natives_data_out = *snapshot_data_out = NULL;
-    *natives_size_out = *snapshot_size_out = 0;
-    return;
-  }
-  *natives_data_out = reinterpret_cast<const char*>(g_mapped_natives->data());
-  *snapshot_data_out = reinterpret_cast<const char*>(g_mapped_snapshot->data());
-  *natives_size_out = static_cast<int>(g_mapped_natives->length());
-  *snapshot_size_out = static_cast<int>(g_mapped_snapshot->length());
-}
-
-IsolateHolder::IsolateHolder() {
-  CHECK(g_array_buffer_allocator)
-      << "You need to invoke gin::IsolateHolder::Initialize first";
-  v8::Isolate::CreateParams params;
-  params.entry_hook = DebugImpl::GetFunctionEntryHook();
-  params.code_event_handler = DebugImpl::GetJitCodeEventHandler();
-  params.constraints.ConfigureDefaults(base::SysInfo::AmountOfPhysicalMemory(),
-                                       base::SysInfo::AmountOfVirtualMemory(),
-                                       base::SysInfo::NumberOfProcessors());
-  isolate_ = v8::Isolate::New(params);
-  isolate_data_.reset(new PerIsolateData(isolate_, g_array_buffer_allocator));
-#if defined(OS_WIN)
-  {
-    void* code_range;
-    size_t size;
-    isolate_->GetCodeRange(&code_range, &size);
-    Debug::CodeRangeCreatedCallback callback =
-        DebugImpl::GetCodeRangeCreatedCallback();
-    if (code_range && size && callback)
-      callback(code_range, size);
-  }
-#endif
-}
-
-IsolateHolder::~IsolateHolder() {
-  if (task_observer_.get())
-    base::MessageLoop::current()->RemoveTaskObserver(task_observer_.get());
-#if defined(OS_WIN)
-  {
-    void* code_range;
-    size_t size;
-    isolate_->GetCodeRange(&code_range, &size);
-    Debug::CodeRangeDeletedCallback callback =
-        DebugImpl::GetCodeRangeDeletedCallback();
-    if (code_range && callback)
-      callback(code_range);
-  }
-#endif
-  isolate_data_.reset();
-  isolate_->Dispose();
-  isolate_ = NULL;
+  return MapV8Files(NULL, NULL, natives_fd, snapshot_fd, natives_region,
+                    snapshot_region);
 }
 
 // static
-void IsolateHolder::Initialize(ScriptMode mode,
-                               v8::ArrayBuffer::Allocator* allocator) {
-  CHECK(allocator);
-  static bool v8_is_initialized = false;
-  if (v8_is_initialized)
-    return;
-  v8::V8::InitializePlatform(V8Platform::Get());
-  v8::V8::SetArrayBufferAllocator(allocator);
-  g_array_buffer_allocator = allocator;
-  if (mode == gin::IsolateHolder::kStrictMode) {
-    static const char use_strict[] = "--use_strict";
-    v8::V8::SetFlagsFromString(use_strict, sizeof(use_strict) - 1);
-  }
-  v8::V8::SetEntropySource(&GenerateEntropy);
-#if defined(V8_USE_EXTERNAL_STARTUP_DATA)
+void V8StartupData::Initialize() {
   v8::StartupData natives;
   natives.data = reinterpret_cast<const char*>(g_mapped_natives->data());
   natives.raw_size = static_cast<int>(g_mapped_natives->length());
@@ -280,21 +204,8 @@ void IsolateHolder::Initialize(ScriptMode mode,
   snapshot.data = reinterpret_cast<const char*>(g_mapped_snapshot->data());
   snapshot.raw_size = static_cast<int>(g_mapped_snapshot->length());
   v8::V8::SetSnapshotDataBlob(&snapshot);
-#endif  // V8_USE_EXTERNAL_STARTUP_DATA
-  v8::V8::Initialize();
-  v8_is_initialized = true;
-}
-
-void IsolateHolder::AddRunMicrotasksObserver() {
-  DCHECK(!task_observer_.get());
-  task_observer_.reset(new RunMicrotasksObserver(isolate_));;
-  base::MessageLoop::current()->AddTaskObserver(task_observer_.get());
 }
 
-void IsolateHolder::RemoveRunMicrotasksObserver() {
-  DCHECK(task_observer_.get());
-  base::MessageLoop::current()->RemoveTaskObserver(task_observer_.get());
-  task_observer_.reset();
-}
+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
 
 }  // namespace gin