Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: content/shell/browser/shell_content_browser_client.cc

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DEPS tweak suggested by jochen. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/browser/shell_content_browser_client.h" 5 #include "content/shell/browser/shell_content_browser_client.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/files/file.h" 9 #include "base/files/file.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 16 matching lines...) Expand all
27 #include "content/shell/browser/shell_browser_main_parts.h" 27 #include "content/shell/browser/shell_browser_main_parts.h"
28 #include "content/shell/browser/shell_devtools_manager_delegate.h" 28 #include "content/shell/browser/shell_devtools_manager_delegate.h"
29 #include "content/shell/browser/shell_net_log.h" 29 #include "content/shell/browser/shell_net_log.h"
30 #include "content/shell/browser/shell_quota_permission_context.h" 30 #include "content/shell/browser/shell_quota_permission_context.h"
31 #include "content/shell/browser/shell_resource_dispatcher_host_delegate.h" 31 #include "content/shell/browser/shell_resource_dispatcher_host_delegate.h"
32 #include "content/shell/browser/shell_web_contents_view_delegate_creator.h" 32 #include "content/shell/browser/shell_web_contents_view_delegate_creator.h"
33 #include "content/shell/browser/webkit_test_controller.h" 33 #include "content/shell/browser/webkit_test_controller.h"
34 #include "content/shell/common/shell_messages.h" 34 #include "content/shell/common/shell_messages.h"
35 #include "content/shell/common/shell_switches.h" 35 #include "content/shell/common/shell_switches.h"
36 #include "content/shell/common/webkit_test_helpers.h" 36 #include "content/shell/common/webkit_test_helpers.h"
37 #include "gin/public/isolate_holder.h" 37 #include "gin/v8_initializer.h"
38 #include "net/url_request/url_request_context_getter.h" 38 #include "net/url_request/url_request_context_getter.h"
39 #include "url/gurl.h" 39 #include "url/gurl.h"
40 40
41 #if defined(OS_ANDROID) 41 #if defined(OS_ANDROID)
42 #include "base/android/path_utils.h" 42 #include "base/android/path_utils.h"
43 #include "components/crash/browser/crash_dump_manager_android.h" 43 #include "components/crash/browser/crash_dump_manager_android.h"
44 #include "content/shell/android/shell_descriptors.h" 44 #include "content/shell/android/shell_descriptors.h"
45 #endif 45 #endif
46 46
47 #if defined(OS_POSIX) && !defined(OS_MACOSX) 47 #if defined(OS_POSIX) && !defined(OS_MACOSX)
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 } 347 }
348 348
349 #if defined(OS_POSIX) && !defined(OS_MACOSX) 349 #if defined(OS_POSIX) && !defined(OS_MACOSX)
350 void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess( 350 void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
351 const base::CommandLine& command_line, 351 const base::CommandLine& command_line,
352 int child_process_id, 352 int child_process_id,
353 FileDescriptorInfo* mappings) { 353 FileDescriptorInfo* mappings) {
354 #if defined(V8_USE_EXTERNAL_STARTUP_DATA) 354 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
355 if (v8_snapshot_fd_.get() == -1 && v8_natives_fd_.get() == -1) { 355 if (v8_snapshot_fd_.get() == -1 && v8_natives_fd_.get() == -1) {
356 base::FilePath v8_data_path; 356 base::FilePath v8_data_path;
357 PathService::Get(gin::IsolateHolder::kV8SnapshotBasePathKey, &v8_data_path); 357 PathService::Get(gin::V8Initializer::kV8SnapshotBasePathKey, &v8_data_path);
358 DCHECK(!v8_data_path.empty()); 358 DCHECK(!v8_data_path.empty());
359 359
360 int file_flags = base::File::FLAG_OPEN | base::File::FLAG_READ; 360 int file_flags = base::File::FLAG_OPEN | base::File::FLAG_READ;
361 base::FilePath v8_natives_data_path = 361 base::FilePath v8_natives_data_path =
362 v8_data_path.AppendASCII(gin::IsolateHolder::kNativesFileName); 362 v8_data_path.AppendASCII(gin::V8Initializer::kNativesFileName);
363 base::FilePath v8_snapshot_data_path = 363 base::FilePath v8_snapshot_data_path =
364 v8_data_path.AppendASCII(gin::IsolateHolder::kSnapshotFileName); 364 v8_data_path.AppendASCII(gin::V8Initializer::kSnapshotFileName);
365 base::File v8_natives_data_file(v8_natives_data_path, file_flags); 365 base::File v8_natives_data_file(v8_natives_data_path, file_flags);
366 base::File v8_snapshot_data_file(v8_snapshot_data_path, file_flags); 366 base::File v8_snapshot_data_file(v8_snapshot_data_path, file_flags);
367 DCHECK(v8_natives_data_file.IsValid()); 367 DCHECK(v8_natives_data_file.IsValid());
368 DCHECK(v8_snapshot_data_file.IsValid()); 368 DCHECK(v8_snapshot_data_file.IsValid());
369 v8_natives_fd_.reset(v8_natives_data_file.TakePlatformFile()); 369 v8_natives_fd_.reset(v8_natives_data_file.TakePlatformFile());
370 v8_snapshot_fd_.reset(v8_snapshot_data_file.TakePlatformFile()); 370 v8_snapshot_fd_.reset(v8_snapshot_data_file.TakePlatformFile());
371 } 371 }
372 mappings->Share(kV8NativesDataDescriptor, v8_natives_fd_.get()); 372 mappings->Share(kV8NativesDataDescriptor, v8_natives_fd_.get());
373 mappings->Share(kV8SnapshotDataDescriptor, v8_snapshot_fd_.get()); 373 mappings->Share(kV8SnapshotDataDescriptor, v8_snapshot_fd_.get());
374 #endif // V8_USE_EXTERNAL_STARTUP_DATA 374 #endif // V8_USE_EXTERNAL_STARTUP_DATA
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 ShellBrowserContext* 441 ShellBrowserContext*
442 ShellContentBrowserClient::ShellBrowserContextForBrowserContext( 442 ShellContentBrowserClient::ShellBrowserContextForBrowserContext(
443 BrowserContext* content_browser_context) { 443 BrowserContext* content_browser_context) {
444 if (content_browser_context == browser_context()) 444 if (content_browser_context == browser_context())
445 return browser_context(); 445 return browser_context();
446 DCHECK_EQ(content_browser_context, off_the_record_browser_context()); 446 DCHECK_EQ(content_browser_context, off_the_record_browser_context());
447 return off_the_record_browser_context(); 447 return off_the_record_browser_context();
448 } 448 }
449 449
450 } // namespace content 450 } // namespace content
OLDNEW
« content/shell/DEPS ('K') | « content/shell/DEPS ('k') | content/test/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698