Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Side by Side Diff: gin/public/isolate_holder.h

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix DEPS for Android Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_ 5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_
6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_ 6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "gin/gin_export.h" 10 #include "gin/gin_export.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 // loop. This method adds a MessageLoop TaskObserver which runs any pending 44 // loop. This method adds a MessageLoop TaskObserver which runs any pending
45 // Microtasks each time a Task is completed. This method should be called 45 // Microtasks each time a Task is completed. This method should be called
46 // once, when a MessageLoop is created and it should be called on the 46 // once, when a MessageLoop is created and it should be called on the
47 // MessageLoop's thread. 47 // MessageLoop's thread.
48 void AddRunMicrotasksObserver(); 48 void AddRunMicrotasksObserver();
49 49
50 // This method should also only be called once, and on the MessageLoop's 50 // This method should also only be called once, and on the MessageLoop's
51 // thread. 51 // thread.
52 void RemoveRunMicrotasksObserver(); 52 void RemoveRunMicrotasksObserver();
53 53
54 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
55 static const int kV8SnapshotBasePathKey;
56 static const char kNativesFileName[];
57 static const char kSnapshotFileName[];
58
59 static bool LoadV8SnapshotFd(int natives_fd,
60 int64 natives_offset,
61 int64 natives_size,
62 int snapshot_fd,
63 int64 snapshot_offset,
64 int64 snapshot_size);
65 static bool LoadV8Snapshot();
66 #endif // V8_USE_EXTERNAL_STARTUP_DATA
67 static void GetV8ExternalSnapshotData(const char** natives_data_out,
68 int* natives_size_out,
69 const char** snapshot_data_out,
70 int* snapshot_size_out);
71
72 private: 54 private:
73 v8::Isolate* isolate_; 55 v8::Isolate* isolate_;
74 scoped_ptr<PerIsolateData> isolate_data_; 56 scoped_ptr<PerIsolateData> isolate_data_;
75 scoped_ptr<RunMicrotasksObserver> task_observer_; 57 scoped_ptr<RunMicrotasksObserver> task_observer_;
76 58
77 DISALLOW_COPY_AND_ASSIGN(IsolateHolder); 59 DISALLOW_COPY_AND_ASSIGN(IsolateHolder);
78 }; 60 };
79 61
80 } // namespace gin 62 } // namespace gin
81 63
82 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_ 64 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698