Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1011133005: Increase tolerance for receiver's certificate expiry (Closed)

Created:
5 years, 9 months ago by dougsteed
Modified:
5 years, 9 months ago
Reviewers:
mark a. foltz
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase tolerance for receiver's certificate expiry Increase the maximum allowed remaining lifetime for the receiver's self-signed cert to 4 days. This is being increased from 2 days because errors are being seen in the field because of sender clocks being off. In the future, we might find a way to warn the user that their clock might be off, but for now just changing the tolerance seems the right approach. BUG=467736 R=mfoltz@chromium.org Committed: https://crrev.com/7018ce63853e5e7464e6604015a76fe82886133e Cr-Commit-Position: refs/heads/master@{#322497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M extensions/browser/api/cast_channel/cast_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dougsteed
5 years, 9 months ago (2015-03-26 04:53:55 UTC) #1
mark a. foltz
lgtm Please add a unit test for cert lifetime checking at some point. Not sure ...
5 years, 9 months ago (2015-03-26 20:58:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011133005/1
5 years, 9 months ago (2015-03-26 22:25:04 UTC) #4
dougsteed
On 2015/03/26 20:58:00, mark a. foltz wrote: > lgtm > > Please add a unit ...
5 years, 9 months ago (2015-03-26 22:31:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 23:32:47 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 23:34:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7018ce63853e5e7464e6604015a76fe82886133e
Cr-Commit-Position: refs/heads/master@{#322497}

Powered by Google App Engine
This is Rietveld 408576698