Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/sync/protocol/proto_value_conversions.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/sync/internal_api/sync_encryption_handler_impl.cc ('k') | trunk/src/sync/syncable/syncable_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/sync/protocol/proto_value_conversions.cc
===================================================================
--- trunk/src/sync/protocol/proto_value_conversions.cc (revision 239920)
+++ trunk/src/sync/protocol/proto_value_conversions.cc (working copy)
@@ -54,7 +54,9 @@
// that instead of a StringValue.
base::StringValue* MakeBytesValue(const std::string& bytes) {
std::string bytes_base64;
- base::Base64Encode(bytes, &bytes_base64);
+ if (!base::Base64Encode(bytes, &bytes_base64)) {
+ NOTREACHED();
+ }
return new base::StringValue(bytes_base64);
}
« no previous file with comments | « trunk/src/sync/internal_api/sync_encryption_handler_impl.cc ('k') | trunk/src/sync/syncable/syncable_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698