Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: trunk/src/sync/internal_api/public/base/unique_position_unittest.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/sync/internal_api/public/base/unique_position_unittest.cc
===================================================================
--- trunk/src/sync/internal_api/public/base/unique_position_unittest.cc (revision 239920)
+++ trunk/src/sync/internal_api/public/base/unique_position_unittest.cc (working copy)
@@ -392,7 +392,7 @@
// random anyway.
std::string input = cache_guid_ + base::Int64ToString(next_id_--);
std::string output;
- base::Base64Encode(base::SHA1HashString(input), &output);
+ CHECK(base::Base64Encode(base::SHA1HashString(input), &output));
return output;
}
« no previous file with comments | « trunk/src/remoting/protocol/v2_authenticator.cc ('k') | trunk/src/sync/internal_api/sync_encryption_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698