Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: trunk/src/jingle/notifier/listener/push_notifications_send_update_task.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/jingle/notifier/listener/push_notifications_send_update_task.cc
===================================================================
--- trunk/src/jingle/notifier/listener/push_notifications_send_update_task.cc (revision 239920)
+++ trunk/src/jingle/notifier/listener/push_notifications_send_update_task.cc (working copy)
@@ -71,14 +71,20 @@
recipient_element->AddAttr(buzz::QN_TO, recipient.to);
if (!recipient.user_specific_data.empty()) {
std::string base64_data;
- base::Base64Encode(recipient.user_specific_data, &base64_data);
- recipient_element->SetBodyText(base64_data);
+ if (!base::Base64Encode(recipient.user_specific_data, &base64_data)) {
+ DLOG(WARNING) << "Could not encode data "
+ << recipient.user_specific_data;
+ } else {
+ recipient_element->SetBodyText(base64_data);
+ }
}
}
buzz::XmlElement* data = new buzz::XmlElement(kQnData, true);
std::string base64_data;
- base::Base64Encode(notification.data, &base64_data);
+ if (!base::Base64Encode(notification.data, &base64_data)) {
+ DLOG(WARNING) << "Could not encode data " << notification.data;
+ }
data->SetBodyText(base64_data);
push->AddElement(data);

Powered by Google App Engine
This is Rietveld 408576698