Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/extensions/common/extension.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/content/shell/renderer/webkit_test_runner.cc ('k') | trunk/src/google_apis/cup/client_update_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/extensions/common/extension.cc
===================================================================
--- trunk/src/extensions/common/extension.cc (revision 239920)
+++ trunk/src/extensions/common/extension.cc (working copy)
@@ -248,10 +248,7 @@
// static
bool Extension::ProducePEM(const std::string& input, std::string* output) {
DCHECK(output);
- if (input.empty())
- return false;
- base::Base64Encode(input, output);
- return true;
+ return (input.length() == 0) ? false : base::Base64Encode(input, output);
}
// static
« no previous file with comments | « trunk/src/content/shell/renderer/webkit_test_runner.cc ('k') | trunk/src/google_apis/cup/client_update_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698