Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/content/shell/browser/webkit_test_controller.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/content/common/page_state_serialization_unittest.cc ('k') | trunk/src/content/shell/renderer/webkit_test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/shell/browser/webkit_test_controller.cc
===================================================================
--- trunk/src/content/shell/browser/webkit_test_controller.cc (revision 239920)
+++ trunk/src/content/shell/browser/webkit_test_controller.cc (working copy)
@@ -170,9 +170,10 @@
*output_ << "Content-Transfer-Encoding: base64\n";
std::string data_base64;
- base::Base64Encode(
+ const bool success = base::Base64Encode(
base::StringPiece(reinterpret_cast<const char*>(&data[0]), data.size()),
&data_base64);
+ DCHECK(success);
*output_ << "Content-Length: " << data_base64.length() << "\n";
output_->write(data_base64.c_str(), data_base64.length());
« no previous file with comments | « trunk/src/content/common/page_state_serialization_unittest.cc ('k') | trunk/src/content/shell/renderer/webkit_test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698