Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: trunk/src/chrome/test/chromedriver/net/websocket.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/test/chromedriver/net/websocket.cc
===================================================================
--- trunk/src/chrome/test/chromedriver/net/websocket.cc (revision 239920)
+++ trunk/src/chrome/test/chromedriver/net/websocket.cc (working copy)
@@ -121,7 +121,7 @@
return;
}
- base::Base64Encode(base::RandBytesAsString(16), &sec_key_);
+ CHECK(base::Base64Encode(base::RandBytesAsString(16), &sec_key_));
std::string handshake = base::StringPrintf(
"GET %s HTTP/1.1\r\n"
"Host: %s\r\n"
@@ -210,8 +210,8 @@
const char kMagicKey[] = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
std::string websocket_accept;
- base::Base64Encode(base::SHA1HashString(sec_key_ + kMagicKey),
- &websocket_accept);
+ CHECK(base::Base64Encode(base::SHA1HashString(sec_key_ + kMagicKey),
+ &websocket_accept));
scoped_refptr<net::HttpResponseHeaders> headers(
new net::HttpResponseHeaders(
net::HttpUtil::AssembleRawHeaders(
@@ -262,3 +262,5 @@
state_ = CLOSED;
}
+
+

Powered by Google App Engine
This is Rietveld 408576698